driver: spi: silabs_siwx91x_gspi: Add pm device support for gspi driver #94373

fimohame · 2025-08-12T07:09:29Z

This commit enables the pm device driver support for the spi_silabs_siwx91x_gspi driver.

smalae · 2025-08-12T09:20:45Z

drivers/spi/spi_silabs_siwx91x_gspi.c

+			return ret;
+		}
+
+		cfg->reg->GSPI_CONFIG1_b.GSPI_MANUAL_CSN = 0;


What about setting the high-performance enable bit?

I checked it wasn't affecting the functionality as such

It will affect functionality when operating at high speed

I have addressed it.

smalae · 2025-08-12T09:44:33Z

drivers/spi/spi_silabs_siwx91x_gspi.c

+			return ret;
+		}
+
+		cfg->reg->GSPI_CONFIG1_b.GSPI_MANUAL_CSN = 0;


It will affect functionality when operating at high speed

drivers/spi/spi_silabs_siwx91x_gspi.c

sonarqubecloud · 2025-08-19T06:56:09Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

drivers/spi/spi_silabs_siwx91x_gspi.c

Martinhoff-maker · 2025-10-08T16:02:53Z

drivers/spi/spi_silabs_siwx91x_gspi.c


 	if (status >= 0 && status != DMA_STATUS_COMPLETE) {
-		return;
+		goto pm_put_exit;


you don't want to put the device runtime if the DMA transfer is not completed. in that case, you could turn off the power domain and then killed the working uDMA.

Martinhoff-maker · 2025-10-08T16:06:20Z

drivers/spi/spi_silabs_siwx91x_gspi.c

+
 	if (!spi_siwx91x_is_dma_enabled_instance(dev) && asynchronous) {
 		ret = -ENOTSUP;
+		goto pm_put_exit;


you will never call the "pm_device_runtime_put" since you are in the case of an asynchronous transfer.

Martinhoff-maker · 2025-10-08T16:07:05Z

drivers/spi/spi_silabs_siwx91x_gspi.c

 		if (ret) {
 			spi_context_release(&data->ctx, ret);
-			return ret;
+			goto pm_put_exit;


same here in the case you are in an asynchronous transfer

drivers/spi/spi_silabs_siwx91x_gspi.c

Martinhoff-maker · 2025-10-17T13:54:01Z

Since SPI will use GPDMA instead of uDMA with #97534, I think we need to implement PM in GPDMA driver in order to have PM properly working with SPI.
Other than that, LGTM now but would like to test with GPDMA and PM.

asmellby · 2025-10-22T09:54:50Z

drivers/spi/spi_silabs_siwx91x_gspi.c

 	}

+	if (!asynchronous) {
+		pm_device_runtime_put(dev);


Unless I'm misunderstanding something, this doesn't seem correct to me. If DMA is used for a blocking transfer, won't the runtime_put already have happened in the DMA complete callback? It seems to me like this should be done inside the else above, and not be related to asynchronous at all.

Your correct. It's been addressed now

This commit enables the pm device driver support for the spi_silabs_siwx91x_gspi driver. Signed-off-by: S Mohamed Fiaz <[email protected]>

sonarqubecloud · 2025-10-22T11:22:26Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Seems like the raised issue has been addressed

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch from acb2e26 to 065dc37 Compare August 12, 2025 09:19

smalae suggested changes Aug 12, 2025

View reviewed changes

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch from 065dc37 to 7e30b65 Compare August 12, 2025 09:32

fimohame marked this pull request as ready for review August 12, 2025 09:42

fimohame requested a review from smalae August 12, 2025 09:42

zephyrbot added area: SPI SPI bus platform: Silabs Silicon Labs labels Aug 12, 2025

zephyrbot requested review from Martinhoff-maker, asmellby, decsny, jerome-pouiller, jhedberg, tbursztyka and teburd August 12, 2025 09:43

zephyrbot assigned jhedberg and asmellby Aug 12, 2025

smalae previously requested changes Aug 12, 2025

View reviewed changes

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch from 7e30b65 to 9dd86ee Compare August 12, 2025 09:51

fimohame requested a review from smalae August 12, 2025 09:51

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch 2 times, most recently from e5de48e to 704902a Compare August 12, 2025 10:05

jerome-pouiller reviewed Aug 12, 2025

View reviewed changes

drivers/spi/spi_silabs_siwx91x_gspi.c Show resolved Hide resolved

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch from 704902a to 08f5860 Compare August 12, 2025 10:22

fimohame requested a review from jerome-pouiller August 12, 2025 10:32

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch 2 times, most recently from d40cc0f to d0e2bd4 Compare August 19, 2025 06:29

decsny removed their request for review August 20, 2025 01:34

Martinhoff-maker reviewed Sep 1, 2025

View reviewed changes

drivers/spi/spi_silabs_siwx91x_gspi.c Outdated Show resolved Hide resolved

fimohame marked this pull request as draft September 24, 2025 06:50

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch 2 times, most recently from 03b0e31 to 24e143f Compare September 24, 2025 21:22

fimohame marked this pull request as ready for review September 25, 2025 07:24

fimohame requested a review from Martinhoff-maker September 25, 2025 07:25

Martinhoff-maker reviewed Oct 8, 2025

View reviewed changes

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch from 24e143f to dd1fc5e Compare October 17, 2025 05:53

zephyrbot added the area: Boards/SoCs label Oct 17, 2025

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch from dd1fc5e to cbfa627 Compare October 17, 2025 07:09

fimohame requested a review from Martinhoff-maker October 17, 2025 11:14

asmellby reviewed Oct 22, 2025

View reviewed changes

driver: spi: silabs_siwx91x_gspi: Add pm device support for gspi driver

a0af92e

This commit enables the pm device driver support for the spi_silabs_siwx91x_gspi driver. Signed-off-by: S Mohamed Fiaz <[email protected]>

fimohame force-pushed the device_pm_silabs_siwx91x_gspi branch from cbfa627 to a0af92e Compare October 22, 2025 10:55

fimohame requested a review from asmellby October 22, 2025 11:03

jerome-pouiller approved these changes Oct 22, 2025

View reviewed changes

Martinhoff-maker approved these changes Oct 22, 2025

View reviewed changes

smalae approved these changes Oct 22, 2025

View reviewed changes

jhedberg approved these changes Oct 22, 2025

View reviewed changes

cfriedt merged commit bae6364 into zephyrproject-rtos:main Oct 22, 2025
26 checks passed

driver: spi: silabs_siwx91x_gspi: Add pm device support for gspi driver #94373

driver: spi: silabs_siwx91x_gspi: Add pm device support for gspi driver #94373

Uh oh!

Conversation

fimohame commented Aug 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 19, 2025

Quality Gate passed

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Martinhoff-maker commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fimohame Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 22, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Martinhoff-maker commented Oct 17, 2025 •

edited

Loading

fimohame Oct 22, 2025 •

edited

Loading