video: fix dcmipp devicetree #94400
Open
video: fix dcmipp devicetree #94400
+94
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver instance variable name is inst, not n. Signed-off-by: Phi Bang Nguyen <[email protected]>
zephyrbot
added
platform: STM32
zephyrbot
requested review from
avisconti,
avolmat-st,
djiatsaf-st,
erwango,
etienne-lms,
FRASTM,
gautierg-st,
GeorgeCGV,
jfischer-no,
josuah,
kartben,
loicpoulain,
marwaiehm-st and
mathieuchopstm
The pipe nodes are not video interfaces. Describe them as normal child nodes instead of using port/endpoint. Signed-off-by: Phi Bang Nguyen <[email protected]>
ngphibang
force-pushed
the
fix_dcmipp_devicetree
branch
from
9dcba5b to
1ea37c5
Compare
|
ngphibang
commented
Aug 14, 2025
Comment on lines
+24
to
+32
| pipes { | ||
| compatible = "st,stm32-dcmipp-pipes"; | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| port@0 { | ||
| pipe_dump: pipe@0 { | ||
| reg = <0>; | ||
|
|
||
| endpoint { | ||
| remote-endpoint-label = ""; | ||
| bus-type = <VIDEO_BUS_TYPE_PARALLEL>; | ||
| }; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
By reviewing #94081, it seems only n6 has multiple pipes and this one has just one pipe ? In this case, pipes {} node is not needed and we can remove compatible string too. Otherwise, need to add an if in the dcmipp driver when retrieving the pipe / pipes:
DT_FOREACH_CHILD_VARGS(DT_INST_CHILD(inst, pipes), DCMIPP_PIPE_INIT_DEFINE, inst);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.