boards: nordic: nrf54h20dk: Reconfigure Trace #94440
Conversation
On a reset the coresight peripherals need to be reset, added an according JLinkScript action. Signed-off-by: Karsten Koenig <[email protected]>
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
|
|
|
||
| int AfterResetTarget(void) | ||
| { | ||
| _needCoresightSetup = 1; |
There was a problem hiding this comment.
If I click "Reset & Break At Symbol" in Ozone I no longer see Instruction Trace. Based on the commit message I was expected this to help. What does this fix exactly? Is it supposed to fix missing Instruction Trace after "Reset & Break At Symbol"?
There was a problem hiding this comment.
You are trying the thing it should improve yes.
Can you try pause and resume a few times after the initial break? The debugger connection gets reset on the reset so Ozone must recover and hence needs a few branches to actually see where the instruction trace is at, even if it knows the current instruction from the program counter. The instruction trace is mostly just branching information if a branch was actually taken, so it needs to capture quite a bit to get an actual address and derive the current instruction from that.
There was a problem hiding this comment.
If I click "Reset & Break At Symbol" in Ozone I no longer see Instruction Trace.
Wait a minute, you didn't see it continue before did you? So you were checking if this made it better and it didn't live up to expectations or does this actually break instruction tracing on reset for you?
There was a problem hiding this comment.
While last week I was getting trace somewhat working if I didn't hit reset, now I am unable to get trace working at all. I just get "No trace clock present, trace may not work correctly."
There was a problem hiding this comment.
That is very strange, this should at worst case cause the coresight subsystem to be configured more often but to the same configuration. Are you sure you are setting CONFIG_SOC_NRF54H20_TDD_ENABLE=y?
I am reworking this part to be more like a proper zephyr driver here, so it'll be a devicetree entry that gets enabled #95124
There was a problem hiding this comment.
Where do I get CONFIG_SOC_NRF54H20_TDD_ENABLE=y from? I do enable NRF_IRONSIDE_TDD_SERVICE and NRF_TRACE_PORT in west build -t menuconfig but I don't see CONFIG_SOC_NRF54H20_TDD_ENABLE anywhere.
There was a problem hiding this comment.
It was a feature I added to unlock using ETM. https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nordic/nrf54h/Kconfig#L69-L78
But in hindsight it was a poor design, I should have gone with the referenced coresight PR #95124 from the start, so tpiu has proper pinctrl, tdd proper power management via a device driver etc. NRF_TRACE_PORT I had not realized existed, I could have probably hidden the TPIU config behind that but think the future pinctrl configuration style is a lot cleaner overall
On a reset the coresight peripherals need to be reset, added an according JLinkScript action.