usb: device_next: hid: allow to set polling period at runtime #94518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josuah
previously approved these changes
Aug 19, 2025
kartben
reviewed
Aug 19, 2025
include/zephyr/usb/class/usbd_hid.h
Outdated
Comment on lines
219
to
220
| * different polling periods at runtime. Depends on Kconfig options | ||
| * USBD_HID_SET_POLLING_PERIOD. |
There was a problem hiding this comment.
Suggested change
| * different polling periods at runtime. Depends on Kconfig options | |
| * USBD_HID_SET_POLLING_PERIOD. | |
| * different polling periods at runtime. | |
| * | |
| * @kconfig_dep{CONFIG_USBD_HID_SET_POLLING_PERIOD} |
tmon-nordic
requested changes
Sep 3, 2025
jfischer-no
force-pushed
the
pr-device_next_hid_binterval
branch
from
4d37563 to
b6fdab8
Compare
|
@tmon-nordic please take another look |
tmon-nordic
reviewed
Sep 12, 2025
Comment on lines
23
to
24
| int (*set_in_polling)(const struct device *dev, const unsigned int value); | ||
| int (*set_out_polling)(const struct device *dev, const unsigned int value); |
There was a problem hiding this comment.
Why name it value and not period_us?
There was a problem hiding this comment.
I think period_us is a more descriptive name as well
jfischer-no
force-pushed
the
pr-device_next_hid_binterval
branch
from
b6fdab8 to
719f1fb
Compare
tmon-nordic
approved these changes
Oct 6, 2025
josuah
approved these changes
Oct 6, 2025
Do not register the device when the class instance has already been initialised. Fail on initialization if no HID device is registered. Signed-off-by: Johann Fischer <[email protected]>
Allow to set input or output report polling period at runtime. Signed-off-by: Johann Fischer <[email protected]>
Add an example of how to set the polling period at runtime. Signed-off-by: Johann Fischer <[email protected]>
kartben
force-pushed
the
pr-device_next_hid_binterval
branch
from
719f1fb to
86aea0a
Compare
|
rebased on main to address CI failure |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to set input or output report polling period at runtime.