esp32 i2s driver improvement and i2s_api test enabling #94519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
LucasTambor,
anangl,
marekmatej,
raffarost,
sylvioalves and
uLipe
uLipe
previously approved these changes
Aug 17, 2025
raffarost
previously approved these changes
Aug 18, 2025
sylvioalves
reviewed
Aug 21, 2025
sylvioalves
reviewed
Aug 21, 2025
sylvioalves
reviewed
Aug 21, 2025
sylvioalves
reviewed
Aug 21, 2025
wmrsouza
force-pushed
the
tests_i2s
branch
3 times, most recently
from
4e76d5f to
5e5ca9f
Compare
zephyrbot
added
area: Xtensa
zephyrbot
requested review from
fkokosinski,
kgugala,
sylvioalves and
tgorochowik
wmrsouza
force-pushed
the
tests_i2s
branch
5 times, most recently
from
298e890 to
84f760e
Compare
zephyrbot
added
area: Boards/SoCs
area: Tests
wmrsouza
force-pushed
the
tests_i2s
branch
2 times, most recently
from
262f707 to
075eb60
Compare
Avoids erroneous memory block freeing when stopping transfers Signed-off-by: Marcio Ribeiro <[email protected]>
Moves the pinctrl_apply_state() call to avoid calling it twice Signed-off-by: Marcio Ribeiro <[email protected]>
Adds missing checks regarding mem_slab and data_format during each stream configuration Signed-off-by: Marcio Ribeiro <[email protected]>
Reworks i2s_esp32_read() and i2s_esp32_write() to allow consistent use of stream->data->state Signed-off-by: Marcio Ribeiro <[email protected]>
Allows to defer processing of an empty tx queue when tx_callback is executed. This prevents error conditions if the tx dma interrupt is generated too early, as occurs with esp32 and esp32s2. Signed-off-by: Marcio Ribeiro <[email protected]>
Reworks log messages to avoid timing issues Signed-off-by: Marcio Ribeiro <[email protected]>
Optimizes i2s_esp32_stream_data and i2s_esp32_stream_conf structs and adds property sanity check according to soc series based on SOC_GDMA_SUPPORTED feature Signed-off-by: Marcio Ribeiro <[email protected]>
…avior Rework to fix state management and I2S_DIR_BOTH behavior across the driver Signed-off-by: Marcio Ribeiro <[email protected]>
Reworks i2s entries on esp32 pinctrl.dtsi and .dts board files and adequates overlay files regarding to i2s samples Signed-off-by: Marcio Ribeiro <[email protected]>
adds the following boards ot i2s_api test: - esp32c3_devkitm - esp32c6_devkitc/esp32c6/hpcore - esp32s3_devkitc/esp32s3/procpu - esp32h2_devkitm Signed-off-by: Marcio Ribeiro <[email protected]>
Adds simplified i2s test for: - esp32 - esp32s2 Signed-off-by: Marcio Ribeiro <[email protected]>
|
raffarost
reviewed
Oct 10, 2025
| } | ||
|
|
||
| err = 0; | ||
| key = irq_lock(); |
There was a problem hiding this comment.
might be worth checking the scope of this lock
it should be confined to just the elements whose access it controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR promotes the following improvements to the esp32 i2s driver: