drivers: flash: esp32: Add async operations #94686
Open
+167
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekmatej
force-pushed
the
feature/deferred_flash_access
branch
2 times, most recently
from
9404fcc to
6b144f1
Compare
marekmatej
force-pushed
the
feature/deferred_flash_access
branch
from
6b144f1 to
02eff93
Compare
|
zephyrbot
requested review from
de-nordic,
LucasTambor,
raffarost,
rghaddab,
uLipe and
wmrsouza
uLipe
reviewed
Aug 26, 2025
There was a problem hiding this comment.
Nice job! I like the idea of using the workqueues for doing such sort of async jobs, I have only one remark, why not expose an option to also make possible to use a dedicated workqueue for flash operations? It would be great since the system workqueue is global and may get heavily loaded on complex applications.
sylvioalves
reviewed
Aug 26, 2025
marekmatej
force-pushed
the
feature/deferred_flash_access
branch
from
02eff93 to
3207595
Compare
uLipe
previously approved these changes
Oct 9, 2025
raffarost
reviewed
Oct 9, 2025
|
@de-nordic would you mind taking a look at the assigned PR? If not please re-assigne to someone else. |
wmrsouza
previously approved these changes
Oct 9, 2025
raffarost
previously approved these changes
Oct 9, 2025
sylvioalves
reviewed
Oct 9, 2025
sylvioalves
reviewed
Oct 9, 2025
Direct flash access can cause exceptions when performed while the flash memory is inaccessible or being modified — for example, when code is executing from PSRAM. To avoid such invalid access, this change introduces asynchronous flash operations that are executed from a safe runtime context via a work queue. This ensures all flash accesses occur only when the flash is valid and accessible. Signed-off-by: Marek Matej <[email protected]>
marekmatej
force-pushed
the
feature/deferred_flash_access
branch
from
3207595 to
ecfaf3c
Compare
sylvioalves
approved these changes
Oct 9, 2025
wmrsouza
approved these changes
Oct 9, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since flash access can be restricted in cases when flash could be invalidated during the operation. Therefore, accessing a flash memory from the code running from the PSRAM could lead to an exception. This work implements asynchronous operations to allow flash access only from the valid runtime.