-
Notifications
You must be signed in to change notification settings - Fork 8k
Bluetooth: CAP: Shell: Add handover shell commands #94940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Thalley
wants to merge
7
commits into
zephyrproject-rtos:main
Choose a base branch
from
Thalley:cap_handover_shell
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ab528f
to
6d01140
Compare
6d01140
to
422bb94
Compare
422bb94
to
3720429
Compare
c378195
to
bf08811
Compare
Depends on #96143 |
bf08811
to
ddbc15a
Compare
Add shell command for unicast to broadcast for the CAP handover procedures. Signed-off-by: Emil Gydesen <[email protected]>
Add documentation and example usage of the unicast_to_broadcast CAP handover command. Signed-off-by: Emil Gydesen <[email protected]>
0-init some non-static global variables to avoid issues with uninitialized values. Also modify the printing of the broadcast sources found slightly. Signed-off-by: Emil Gydesen <[email protected]>
Refactor how receive states are handled in the BAP shell. The scan delegator's receive states are not available from the broadcast sink, and the broadcast sink makes sure to properly set the pa_sync object in the receive state struct. The receive states are now also using the BAP service data to identity the receive state when using PAST. The broadcast assistant will now cache data from a remote device, and makes it available to e.g. CAP. Additionally if there is a broadcast source, we cache the values neccesary to identity if a remote receive state represents our local broadcast source. Signed-off-by: Emil Gydesen <[email protected]>
Implement the shell command for handing over broadcast to unicast. The command supports various configurations. It is currently limited to cases with - 1 connection and multiple streams - Multiple connections and 1 stream - Equal amount of streams and connections Cases with e.g. 3 connections and 2 streams, or vice versa, are not support given the complexity of these cases. Signed-off-by: Emil Gydesen <[email protected]>
Add documentation and example usage of the broadcast_to_unicast CAP handover command. Signed-off-by: Emil Gydesen <[email protected]>
Instead of defining the same arguments in all 3 CAP files, we declare them in audio.h and initiate them in either the initiator or commander, depending on their use. The reason for this change, is that the CAP Handover API require several of the parameter to be globally/statically allocated, and cannot just rely on stack allocated parameters. By doing this, we can use the same argument among the CAP shell modules, while keeping the memory usage down. This has the additional postive effect that we do not allocate some of these arrays, which can be quite larger, on the stack. Signed-off-by: Emil Gydesen <[email protected]>
ddbc15a
to
384e23e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shell commands for the CAP handover procedures.