-
Notifications
You must be signed in to change notification settings - Fork 8.1k
NXP boards: nxp: frdm_ke16z: New board with 64kB Flash device added #94956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
LPFLL (soc: scg: "lpfll_clk") clock source can be now selected in KE1xz Device tree (nxp_ke1xz.dtsi., board.dts or overlay) Tested on boards: frdm_ke15z, frdm_ke17z, frdm_ke17z512 Signed-off-by: Michael Galda <[email protected]>
58ee712
to
ae4a5eb
Compare
SOC_MKE16z4 and MKE15z4 (64kB, 48MHz) is now supported by DT LPFLL clock option with proper frequency select dts: nxp_ke1xz64.dtsi added. Tested on board: frdm_ke16z Signed-off-by: Michael Galda <[email protected]>
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending on how similar all the KE boards are, you might want to consider combining them all into the same folder and sharing files. Because the amount of files to maintain is getting out of hand otherwise if they are mostly the same board but with a very slightly different chip
Hi Declan, yes I see. It is oppositely, the KE devices are very similar and the FRDM boards contains similar peripherals, but routed to a different pins (due different packages, nobody cared about the pin compatibility). I believe it could be somehow combined, creating some overlays, etc.. But it would add even more mess. |
Do you know that multiple boards can be defined in the same folder at least? You can define as many boards in the board.yml as you want. If there is any reasonable similarity, I think they should go in same folder. But up to you. Same comment for MCXC and MCXA but I don't know who is responsible for those. |
@mgalda82 I updated your PR to address the west.yml conflict Please address the compliance issues. From what I can see, you are mixing spaces with tabs at the beginning of lines. Just use tabs in most cases. In cases where you are trying to align a continuation line you can do the tabs to align with the line above then spaces to do any tweaks. |
Hi David, is there anything still wrong, or have you already fixed and updated it, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for answer about why new board folder is needed
Hi Declan, I understand your care. |
I'm fine with a board for this new FRDM board. @mgalda82 I've updated your PR to address the west.yml changes needed, fix the compliance issue in soc.c, rebased to main and force pushed your branch. Now we wait on CI |
All is fine with the PR. We just need to clean up the compliance check problem (space) and address the documentation build. There was a recent repo-wide change made with the doc pages so I suspect you need to adjust your doc page to align. |
TSI (Touch Sensing IP) is now supported by DT for the Kinetis KE1x family dts: nxp_ke1xz, nxp_ke17z and nxp_ke17z512.dtsi Tested on freedom boards Signed-off-by: Michael Galda <[email protected]>
|
boards: nxp: frdm_ke16z: New board with 64kB device added
Related to HAL_NXP: PR#595
zephyrproject-rtos/hal_nxp#595
SOC_MKE16z4 and MKE15z4 (64kB, 48MHz) is now supported by DT
LPFLL clock option with proper frequency select
dts: nxp_ke1xz64.dtsi added.
lpfll_clk node defined in specific dts files, because of different frequency support
Tested on board: frdm_ke16z with "hello_world" and "blinky"
Signed-off-by: Michael Galda [email protected]