drivers/espi: rts5912: handler all port 80 data until fifo is empty #95005
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
JasonLin-RealTek,
VenkatKotakonda,
albertofloyd and
jvasanth1
|
JasonLin-RealTek
previously approved these changes
Sep 2, 2025
keith-zephyr
reviewed
Oct 6, 2025
drivers/espi/espi_realtek_rts5912.c
Outdated
| espi_send_callbacks(&espi_data->callbacks, dev, evt); | ||
| int32_t start_time = k_uptime_get_32(); | ||
|
|
||
| while (!(port80_reg->STS & PORT80_STS_FIFOEM)) { |
There was a problem hiding this comment.
As implemented, you are including the time spent in the callback as part of the timeout check. If the callback is slow, this will cause a false timeout. You should exclude the callback time in this calculation.
Also note that it's recommended to use the 64-bit version of k_uptime_get()
JhanBoChao-Realtek
force-pushed
the
rts5912_port80_fifo
branch
2 times, most recently
from
e8eeda1 to
9778151
Compare
VenkatKotakonda
approved these changes
Oct 13, 2025
JhanBoChao-Realtek
force-pushed
the
rts5912_port80_fifo
branch
from
9778151 to
06d2cdc
Compare
The rts5912's port 80 has a FIFO. In the ISR (Interrupt Service Routine), extract the FIFO data until the FIFO is empty, otherwise port 80 data will be lost. Signed-off-by: jhan bo chao <[email protected]>
JhanBoChao-Realtek
force-pushed
the
rts5912_port80_fifo
branch
from
06d2cdc to
71429ed
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rts5912's port 80 has a FIFO. In the ISR (Interrupt Service Routine), extract the FIFO data until the FIFO is empty, otherwise port 80 data will be lost.