-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Enable multicore samples for imx943 evk #95046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable multicore samples for imx943 evk #95046
Conversation
5674cb9
to
23ebfba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I have some nits.
23ebfba
to
c3681f3
Compare
c3681f3
to
8bf4094
Compare
d87848f
to
13fb772
Compare
13fb772
to
c41b7b6
Compare
@biwenli can you address the merge conflicts |
c41b7b6
to
3f25e71
Compare
done. |
@JiafeiPan you should be the assignee on this PR |
Hi, @biwenli , please rebase this PR as dependency has been merged. |
sure, np. |
82cc38e
to
3332b7b
Compare
/* Note: please enable lpuart3 and disable lpuart8 for debugging via JTAG */ | ||
zephyr,console = &lpuart8; | ||
zephyr,shell-uart = &lpuart8; | ||
//zephyr,console = &lpuart3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove commented code - here and in the rest of this PR.
Otherwise, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove commented code - here and in the rest of this PR. Otherwise, looks good.
sure, np.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove commented code - here and in the rest of this PR. Otherwise, looks good.
sure, np.
3332b7b
to
7e609c6
Compare
samples/subsys/ipc/ipc_service/static_vrings/boards/imx943_evk_mimx94398_m7_1.overlay
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s still a lot of commented-out code - either remove it or add an explanation for why it’s there.
If you need to explain how a user should switch between m7_0 and m7_1, consider adding that information in a README file.
samples/subsys/ipc/openamp/boards/imx943_evk_mimx94398_m7_0.overlay
Outdated
Show resolved
Hide resolved
samples/subsys/ipc/openamp/boards/imx943_evk_mimx94398_m7_1.overlay
Outdated
Show resolved
Hide resolved
samples/subsys/ipc/openamp/remote/boards/imx943_evk_mimx94398_m33.overlay
Show resolved
Hide resolved
samples/subsys/ipc/openamp/remote/boards/imx943_evk_mimx94398_m7_0.overlay
Show resolved
Hide resolved
samples/subsys/ipc/openamp/remote/boards/imx943_evk_mimx94398_m7_1.overlay
Show resolved
Hide resolved
This commit adds support for these multicore samples: - samples/drivers/mbox - samples/drivers/mbox_data - samples/subsys/ipc/ipc_service/static_vrings - samples/subsys/ipc/openamp Note: - Please modify imx943_evk_mimx94398_<core name>.overlay when you want to check ipc between m7_0 and m7_1 (core name: m33, m7_0, m7_1) Signed-off-by: Biwen Li <[email protected]>
Add lpuart3 node for debugging via JTAG interface Signed-off-by: Biwen Li <[email protected]>
This commit fixes spell and add info to debugging system via JTAG interface. Signed-off-by: Biwen Li <[email protected]>
7e609c6
to
2bcb1d8
Compare
|
Enable multicore samples between mcus(m33s in NETCMIX, M7_0 in M7MIX0, M7_1 in M7MIX1) for imx943 evk