tests: posix: common: use realtime clock instead of monotonic #95225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the realtime clock, since that is always guaranteed to be available with _POSIX_TIMERS. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
added
area: Tests
11 tasks
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates POSIX test files to use the realtime clock (CLOCK_REALTIME) instead of the monotonic clock (CLOCK_MONOTONIC) to ensure compatibility with systems that only guarantee availability of the realtime clock under _POSIX_TIMERS.
- Replaces
CLOCK_MONOTONICwithCLOCK_REALTIMEin timing-related test functions - Adds
#include <time.h>to both test files to ensure proper clock type definitions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/posix/common/src/pthread.c | Updates clock type in pthread timedjoin test and adds time.h include |
| tests/posix/common/src/mutex.c | Updates clock type in mutex timedlock test and adds time.h include |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pdgendt
approved these changes
Sep 8, 2025
cfriedt
deleted the
tests-posix-use-realtime-clock-instead-of-monotonic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates POSIX test files to use the realtime clock (
CLOCK_REALTIME) instead of the monotonic clock (CLOCK_MONOTONIC) to ensure compatibility with systems that only guarantee availability of the realtime clock under_POSIX_TIMERS.CLOCK_MONOTONICwithCLOCK_REALTIMEin timing-related test functions#include <time.h>to both test files to ensure proper clock type definitionsRequired by #88547