Skip to content

stm32wbax 802154 driver support #95376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 27, 2025
Merged

stm32wbax 802154 driver support #95376

merged 5 commits into from
Sep 27, 2025

Conversation

vtardy-st
Copy link
Contributor

@vtardy-st vtardy-st commented Sep 3, 2025 •
edited
Loading

Add support of 802.15.4 driver for STM32WBA
Update Kconfig/CMakeLists/dts/bindings related to 802.15.4 support for STM32WBA
In soc/stm32, update files to support of 802.15.4 on STM32WBA
Enable ieee802154 node for nucleo_wba65ri board

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_stm32 zephyrproject-rtos/hal_stm32@2459cda zephyrproject-rtos/hal_stm32@dc7c254 (main) zephyrproject-rtos/[email protected]

Additional metadata changed:

Name URL Submodules West cmds module.yml Blobs
hal_stm32 ✏ 2x 🆕

⛔ DNM label due to: 1 project with metadata changes and 2 blob changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Added labels Sep 3, 2025
msmttchr
msmttchr suggested changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@msmttchr msmttchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtardy-st, I have submitted a couple of comments, but I have realized that possibly a rebase is needed, before further review. Could you please rebase the code and re-submit?

@vtardy-st vtardy-st force-pushed the stm32wbax_802154_driver_support branch from f1be45e to 9f01ddc Compare September 3, 2025 13:52
HoZHel
HoZHel reviewed Sep 3, 2025
View reviewed changes
msmttchr
msmttchr reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@msmttchr msmttchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explore the possibility of "merging" hci_if/ble and hci_if/IEEE802154 directories ? I think they perform similar functions.

@vtardy-st vtardy-st force-pushed the stm32wbax_802154_driver_support branch 3 times, most recently from 021428a to a3f47ba Compare September 5, 2025 13:35
msmttchr
msmttchr reviewed Sep 8, 2025
View reviewed changes
@vtardy-st vtardy-st force-pushed the stm32wbax_802154_driver_support branch 2 times, most recently from 816cc3b to 2b1fa83 Compare September 9, 2025 13:34
@vtardy-st vtardy-st marked this pull request as ready for review September 10, 2025 08:05
@erwango erwango removed DNM (manifest) This PR should not be merged (controlled by action-manifest) platform: nRF Nordic nRFx platform: Silabs Silicon Labs area: Wi-Fi Wi-Fi labels Sep 23, 2025
@vtardy-st vtardy-st force-pushed the stm32wbax_802154_driver_support branch from 114ce47 to cbdc3c3 Compare September 24, 2025 08:20
@github-actions github-actions bot added the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Sep 24, 2025
@zephyrbot zephyrbot requested a review from erwango September 24, 2025 08:22
@etienne-lms
Copy link
Contributor

I'm not sure it's a good idea to have the manifest updated from its specific commit. At least the manifest update commit being after the commit enabling 802.15.4 on nucleo_wba65ri would also make that board to fail to build on that commit. Will earlier changes in the driver would make wba65 boards with BLE enabled to fail to build.

I wonder if at least the commit that updates the manifest could be placed first in the series.

@vtardy-st
west.yml: update hal_stm32 version
15d36ca 
Update hal_stm32 version to latest commit:
dc7c2543a079c57a4e7dbee54ed7877880dc235b

Signed-off-by: Vincent Tardy <[email protected]>
@vtardy-st
drivers: ieee802154: add support of 802.15.4 for STM32WBA
c0514c0 
Add the driver itself and Kconfig/CMakeLists/dts/bindings related to it.
Other files and libraries needed are in ST's dedicated folder
hal_stm32 (modules/hal/stm32).

Signed-off-by: Vincent Tardy <[email protected]>
@vtardy-st
MAINTAINERS: Add driver ieee 802.15.4 for STM32 Wireless Platform
a1d1e52 
Add ieee802154 driver in STM32 Wireless Platform section

Signed-off-by: Vincent Tardy <[email protected]>
@vtardy-st
soc: stm32: add 802.15.4 support for STM32WBA
a53b239 
Add 802.15.4 support in hci_if files

Signed-off-by: Vincent Tardy <[email protected]>
@vtardy-st
boards: st: nucleo_wba65ri: enable ieee802154 node
8f63660 
enable ieee802154 node for nucleo_wba65ri

Signed-off-by: Vincent Tardy <[email protected]>
@vtardy-st vtardy-st force-pushed the stm32wbax_802154_driver_support branch from cbdc3c3 to 8f63660 Compare September 24, 2025 13:19
@zephyrbot zephyrbot requested a review from erwango September 24, 2025 13:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarQube Cloud

@erwango
Copy link
Member

erwango commented Sep 25, 2025 •
edited
Loading

@cfriedt, @jhedberg Last remaining "issues" of this PR are the points linked to MAINTAINERS update (not even sure of that one) and Binary Blob addition (which is not dealt by TSC anymore so I guess it's up to you).

@cfriedt
Copy link
Member

cfriedt commented Sep 25, 2025

@erwango - looks generally fine to me. @nashif and @MaureenHelm can comment on the MAINTAINERS file.

@erwango
Copy link
Member

erwango commented Sep 26, 2025

@erwango - looks generally fine to me. @nashif and @MaureenHelm can comment on the MAINTAINERS file.

Thanks @cfriedt. Do you know who has the final word on the DNM label ?

@nashif nashif removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Sep 26, 2025
@cfriedt cfriedt merged commit a2691c6 into zephyrproject-rtos:main Sep 27, 2025
31 of 32 checks passed
@github-actions GitHub Actions
Copy link

Hi @vtardy-st!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nashif nashif nashif approved these changes

@cfriedt cfriedt cfriedt approved these changes

@erwango erwango erwango approved these changes

@etienne-lms etienne-lms etienne-lms approved these changes

@asm5878 asm5878 asm5878 approved these changes

@ankuns ankuns Awaiting requested review from ankuns

@benothmn-st benothmn-st Awaiting requested review from benothmn-st

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@rlubos rlubos Awaiting requested review from rlubos

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@anangl anangl Awaiting requested review from anangl

@asmellby asmellby Awaiting requested review from asmellby

@jhedberg jhedberg Awaiting requested review from jhedberg

@jukkar jukkar Awaiting requested review from jukkar

@krish2718 krish2718 Awaiting requested review from krish2718

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

@nika-nordic nika-nordic Awaiting requested review from nika-nordic

@sachinthegreen sachinthegreen Awaiting requested review from sachinthegreen

@HoZHel HoZHel Awaiting requested review from HoZHel

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

+2 more reviewers

@msmttchr msmttchr msmttchr approved these changes

@AhmedFaizyST AhmedFaizyST AhmedFaizyST approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erwango erwango

Labels

area: IEEE 802.15.4 area: MAINTAINER File Binary Blobs Added manifest manifest-hal_stm32 platform: STM32 ST Micro STM32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.