You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tomi-font I wonder if the CI issue is something that looks familiar to you?
Yeah, CMake for this source file should probably link to Mbed TLS as a library so the source file gets the include paths. Has this been fixed yet in main?
@tomi-font I wonder if the CI issue is something that looks familiar to you?
Yeah, CMake for this source file should probably link to Mbed TLS as a library so the source file gets the include paths. Has this been fixed yet in main?
I believe this is fixed by #94881 (and I mixed up Mbed TLS with TF-M), in subsys/settings/src/CMakeLists.txt. So either wait for it to go in or add the fix to your PR. (...Or someone submit the fix as a separate PR.) cc @dsseng@seankyer
I believe this is fixed by #94881 (and I mixed up Mbed TLS with TF-M), in subsys/settings/src/CMakeLists.txt. So either wait for it to go in or add the fix to your PR. (...Or someone submit the fix as a separate PR.) cc @dsseng@seankyer
Didn't test, but looks like this can be fixed by my PR. I should probably finish it today, thanks for reviewing, now I know all I need
This was missing despite other mikrobus labels being there. Verified
against LPCXpresso55S69_Board_Schematic_RevA2_dec4.pdf
Signed-off-by: Benjamin Cabé <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zephyrbot
requested review from
butok,
decsny,
DerekSnell,
dleach02,
EmilioCBen and
mmahadevan108
This was missing despite other mikrobus labels being there. Verified against LPCXpresso55S69_Board_Schematic_RevA2_dec4.pdf