bluetooth: add macros for BT_BAP_PAST_SERVICE_DATA

[iliar]

This commit adds macros for packing and extracting PAST service data for BAP.
Fixes #95337

[Thalley]

Thankss for your contribution. Some formatting comments, but mostly requests to add users of this new macro so that we can verify that it works :)

[kartben]

@iliar please rebase on main

[Thalley]

I think there are a few mistakes that needs to be fixed

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
27.1% Duplication on New Code

See analysis details on SonarQube Cloud

[Thalley]

We have a 100-line maximum in Zephy, so we could do

Suggested change

	((uint16_t)(_src_id) & 0xFFU) << 8U \
	| ((uint16_t)(_past_flags) & 0xFFU)
	((uint16_t)(_src_id) & 0xFFU) << 8U | ((uint16_t)(_past_flags) & 0xFFU)

else I would put the | on the first line

Suggested change

	((uint16_t)(_src_id) & 0xFFU) << 8U \
	| ((uint16_t)(_past_flags) & 0xFFU)
	((uint16_t)(_src_id) & 0xFFU) << 8U | \
	((uint16_t)(_past_flags) & 0xFFU)

[Thalley]

Our coding guidelines require that all functions that may return an error, shall have the return value checked, so this must be

Suggested change

	bt_le_ext_adv_get_info(ext_adv, &info);
	err = bt_le_ext_adv_get_info(ext_adv, &info);

In cases like this where it should never fail unless something terribly has happened, I'd test this with an ASSERT

Suggested change

	bt_le_ext_adv_get_info(ext_adv, &info);
	err = bt_le_ext_adv_get_info(ext_adv, &info);
	__ASSERT(err == 0, "Failed to get adv info: %d", err);

This also applies to the other cases in this PR

[Thalley]

Suggested change

	uint8_t src_id = info.sid;
	err = bt_le_per_adv_sync_transfer(g_pa_sync,
	conn,
	BT_BAP_PAST_SERVICE_DATA(past_flags, src_id));
	err = bt_le_per_adv_sync_transfer(g_pa_sync,
	conn,
	BT_BAP_PAST_SERVICE_DATA(past_flags, info.src_id));

[Thalley]

Suggested change

	bt_le_per_adv_sync_get_info(g_pa_sync, &info);
	uint8_t src_id = info.sid;
	err = bt_le_per_adv_sync_transfer(g_pa_sync,
	conn,
	BT_BAP_PAST_SERVICE_DATA(past_flags, src_id));
	bt_le_per_adv_sync_get_info(g_pa_sync, &info);
	err = bt_le_per_adv_sync_transfer(g_pa_sync,
	conn,
	BT_BAP_PAST_SERVICE_DATA(past_flags, info.src_id));

[iliar]

Thanks for feedback.
but I am getting this error:
error: ‘struct bt_le_per_adv_sync_info’ has no member named ‘src_id’

The defintion looks like this:

/** @brief Periodic advertising set info structure. */
struct bt_le_per_adv_sync_info {
	/** Periodic Advertiser Address */
	bt_addr_le_t addr;

	/** Advertising Set Identifier, valid range @ref BT_GAP_SID_MIN to @ref BT_GAP_SID_MAX. */
	uint8_t sid;

	/** Periodic advertising interval (N * 1.25 ms) */
	uint16_t interval;

	/** Advertiser PHY (see @ref bt_gap_le_phy). */
	uint8_t phy;
};

[Thalley]

Ah, this is on me. It's not the sid that we need, but the src_id of the receive state. bt_le_per_adv_sync_get_info and bt_le_ext_adv_get_info shouldn't be used for this purpose. Sorry for a bad recommendation when I suggested that :D

We need to store the src_id of the receive state somewhere and then use that use. I confused myself with sid, which is not the same as src_id