Add frdm_mcxe31b board basic support #95560
Open
+2,921
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucien-nxp
force-pushed
the
add_mcxe31x_baseline_support
branch
from
6017e5b to
0d95a80
Compare
lucien-nxp
changed the title
zephyrbot
added
platform: NXP Drivers
zephyrbot
requested review from
Dat-NguyenDuy,
DerekSnell,
EmilioCBen,
JiafeiPan,
PetervdPerk-NXP,
ZhaoxiangJin,
bperseghetti,
butok,
congnguyenhuu,
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108 and
nordic-krch
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_nxp
DNM (manifest)
lucien-nxp
force-pushed
the
add_mcxe31x_baseline_support
branch
from
0d95a80 to
5d68882
Compare
lucien-nxp
changed the title
lucien-nxp
force-pushed
the
add_mcxe31x_baseline_support
branch
from
5d68882 to
3ef987b
Compare
nordicjm
reviewed
Sep 30, 2025
|
|
||
| #if DT_NODE_HAS_COMPAT_STATUS(DT_NODELABEL(fxosc), nxp_fxosc, okay) | ||
| const fxosc_config_t fxosc_config = {.freqHz = NXP_FXOSC_FREQ, | ||
| .workMode = NXP_FXOSC_WORKMODE, |
There was a problem hiding this comment.
have these files been put through clang-format? Because the struct here looks very odd
There was a problem hiding this comment.
Have used clang-format command to format this file.
nordicjm
requested changes
Sep 30, 2025
drivers/pinctrl/Kconfig.nxp_siul2
Outdated
| default y | ||
| depends on DT_HAS_NXP_S32ZE_SIUL2_PINCTRL_ENABLED || DT_HAS_NXP_S32K3_SIUL2_PINCTRL_ENABLED | ||
| depends on DT_HAS_NXP_S32ZE_SIUL2_PINCTRL_ENABLED || DT_HAS_NXP_S32K3_SIUL2_PINCTRL_ENABLED || \ | ||
| DT_HAS_NXP_MCXE31X_SIUL2_PINCTRL_ENABLED |
There was a problem hiding this comment.
Suggested change
| DT_HAS_NXP_MCXE31X_SIUL2_PINCTRL_ENABLED | |
| DT_HAS_NXP_MCXE31X_SIUL2_PINCTRL_ENABLED |
| cpus { | ||
| #address-cells = <0x1>; | ||
| #size-cells = <0>; | ||
| core0: cpu@0 { |
There was a problem hiding this comment.
missing newline on line 15
| &peripheral { | ||
| #address-cells = <1>; | ||
| #size-cells = <1>; | ||
| adc_0: adc@a0000 { |
There was a problem hiding this comment.
Sorry, I ignore the first sub-node. I have checked all the dts files and corrected them.
| @@ -0,0 +1,10 @@ | |||
| # | |||
| # Copyright 2025 NXP | |||
There was a problem hiding this comment.
remove excess spacing from commit title
boards/nxp/frdm_mcxe31b/Kconfig
Outdated
| # Copyright 2025 NXP | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config NXP_MCXE31X_BOOT_HEADER |
| /* | ||
| * Copyright 2025 NXP | ||
| * | ||
| * SPDXLicense-Identifier: Apache-2.0 |
|
|
||
| leds { | ||
| compatible = "gpio-leds"; | ||
| red_led: led_0 { |
There was a problem hiding this comment.
I can still see a missing newline on line 37 and other places, Fix in the whole PR
dleach02
force-pushed
the
add_mcxe31x_baseline_support
branch
from
d777dfa to
96f1e57
Compare
github-actions
bot
removed
the
DNM (manifest)
zephyrbot
added
platform: NXP MCU
area: Boards/SoCs
area: Tests
|
@lucien-nxp I merged the HAL side PR and updated this PR for you. |
lucien-nxp
force-pushed
the
add_mcxe31x_baseline_support
branch
from
96f1e57 to
9399c1a
Compare
github-actions
bot
added
the
DNM (manifest)
Updated hal_nxp to add mcxe31x pinctrl.h Signed-off-by: Lucien Zhao <[email protected]>
- add clock_init function to initialize clock sources according devicetree settings - finish basic clock api function Signed-off-by: Lucien Zhao <[email protected]>
- adapt for mcxe31x series - due to some bit defined in header files add some conditional macro to separate Signed-off-by: Lucien Zhao <[email protected]>
- add binding files: nxp,mcxe31x-siul2-pinctrl.yaml - Enable PINCTRL_NXP_SIUL2 when nxp,mcxe31x-siul2-pinctrl is ok Signed-off-by: Lucien Zhao <[email protected]>
- create 'mcxe' as family and 'mcxe31x' as series - add pinctrl_soc.h - add soc.c/.h to do some soc level initialization - add ecc initialization in mcxe31x_soc_initialization.S Signed-off-by: Lucien Zhao <[email protected]>
- Generate a full devices device tree file - Use specific_part.dtsi + full_devices.dtsi way to desribe all devices Signed-off-by: Lucien Zhao <[email protected]>
lucien-nxp
force-pushed
the
add_mcxe31x_baseline_support
branch
from
9399c1a to
328b205
Compare
github-actions
bot
removed
the
DNM (manifest)
- support XIP way to boot
- add board doc and picture
- enable cases below:
hello_world/blinky/button/
philosophers/synchronization/
gpio_basic_api
Signed-off-by: Lucien Zhao <[email protected]>
lucien-nxp
force-pushed
the
add_mcxe31x_baseline_support
branch
from
328b205 to
28ba883
Compare
|
| #ifndef _ASMLANGUAGE | ||
|
|
||
| #include <fsl_common.h> | ||
|
|
There was a problem hiding this comment.
Add an include to soc_common.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello_world/blinky/button/philosophers/synchronization