Bluetooth: BAP: BASE: Split bt_bap_base_get_base_from_ad #95594
Conversation
Thalley
force-pushed
the
bap_base_split
branch
from
8929aae to
b3dfde8
Compare
zephyrbot
requested review from
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot and
sjanc
subsys/bluetooth/audio/bap_base.c
Outdated
| } | ||
|
|
||
| if (net_buf->len < BASE_CODEC_ID_SIZE) { | ||
| LOG_DBG("Invalid BASE length: %u", net_buf->size); |
There was a problem hiding this comment.
Here we have a lot of duplicate LOG_DBG("Invalid BASE length: %u", net_buf->size);, it would be hard to identify which one it is from debug log.
It would be better to add more info, such as:
LOG_DBG("Invalid BASE length: %u, for codec id", net_buf->size);
Thalley
force-pushed
the
bap_base_split
branch
from
b3dfde8 to
8095eb1
Compare
Thalley
requested review from
ChangNice and
Copilot
and removed request for
ChangNice
There was a problem hiding this comment.
Pull Request Overview
Refactors the bt_bap_base_get_base_from_ad function by extracting subgroup validation logic into a separate base_pull_subgroup function to reduce complexity and address Sonarcloud code quality concerns.
- Extracts subgroup parsing logic into a new static function
base_pull_subgroup - Simplifies the main function by replacing inline validation with function calls
- Updates
bt_bap_base_foreach_subgroupto use the new helper function
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thalley
force-pushed
the
bap_base_split
branch
from
8095eb1 to
d02d698
Compare
Thalley
force-pushed
the
bap_base_split
branch
from
d02d698 to
4ce7557
Compare
Split the subgroup validation from bt_bap_base_get_base_from_ad into a new function base_pull_subgroup to make the function simpler and make Sonarcloud happy. The new function, base_pull_subgroup, is also used in the bt_bap_base_foreach_subgroup to reduce code duplication. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_base_split
branch
from
4ce7557 to
e5b3d68
Compare
|
4 participants
Split the subgroup validation from
bt_bap_base_get_base_from_ad into a new function
base_pull_subgroup to make the function simpler and make Sonarcloud happy.