Enable temperature sensor on rt700 #95630

ZhaoxiangJin · 2025-09-08T03:27:42Z

Enable nxp pmc temperature sensor (pmc-tmpsns) driver.
enable pmc-tmpsns on RT700
tested with samples/sensor/die_temp_polling
test result:

*** Booting Zephyr OS build v4.2.0-3691-gd3f239dcd8d6 ***
CPU Die temperature[temp0]: 25.8 °C
CPU Die temperature[temp0]: 25.6 °C
CPU Die temperature[temp0]: 24.9 °C
CPU Die temperature[temp0]: 25.2 °C
CPU Die temperature[temp0]: 25.3 °C
CPU Die temperature[temp0]: 25.6 °C
CPU Die temperature[temp0]: 25.1 °C
CPU Die temperature[temp0]: 25.1 °C
CPU Die temperature[temp0]: 25.1 °C
CPU Die temperature[temp0]: 25.1 °C

github-actions · 2025-09-08T03:33:11Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

ZhaoxiangJin · 2025-09-26T16:57:43Z

Hello @MaureenHelm, could you please revisit this pr? I think all your comments have been fixed. Thanks!

MaureenHelm · 2025-09-29T21:28:43Z

dts/arm/nxp/nxp_rt7xx_cm33_cpu0.dtsi

+	mbox4: mailbox@189000 {
+		#mbox-cells = <1>;
+
+		compatible = "nxp,mbox-imx-mu";
+		reg = <0x189000 0x1000>;
+
+		interrupts = <31 0>;
+		rx-channels = <4>;
+
+		status = "disabled";
+	};
+
+	pmc_tmpsns: pmc-tmpsns {
+		compatible = "nxp,pmc-tmpsns";
+		status = "disabled";
+	};
+};
+
+&systick {
+	/*
+	 * RT700 cm33_cpu0 relies by default on the OS Timer for system
+	 * clock implementation, so the SysTick node is not to be enabled.
+	 */
+	status = "disabled";


Some extra stuff is being added that looks unrelated to the sensor. Rebasing mistake?

sorry for that, it would be a accident, i will update shortly

ZhaoxiangJin · 2025-09-29T22:18:23Z

This PR will get twister failures as know issue #96718

drivers/sensor/nxp/nxp_pmc_tmpsns/nxp_pmc_tmpsns.c

dts/bindings/sensor/nxp,pmc-tmpsns.yaml

boards/nxp/mimxrt700_evk/board.c

ZhaoxiangJin · 2025-10-03T12:08:48Z

@jeppenodgaard, please review

sonarqubecloud · 2025-10-03T12:30:26Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jeppenodgaard · 2025-10-03T14:11:29Z

@jeppenodgaard, please review

LGTM. Other requests needs to be addressed before I can approve.

MaureenHelm

Looks ok, but need to resolve the twister failures

ZhaoxiangJin · 2025-10-03T15:03:09Z

Looks ok, but need to resolve the twister failures

I can reproduce this issue on zephyr latest main branch, hello @hakehuang, did you catch this issue? Thanks.

hakehuang · 2025-10-05T02:36:06Z

I can reproduce this issue on zephyr latest main branch, hello @hakehuang, did you catch this issue? Thanks.

Thanks #97020 @ZhaoxiangJin

Pull in romapi for RT7xx Signed-off-by: Zhaoxiang Jin <[email protected]>

This commit introduced NXP pmc temperature sensor (pmc-tmpsns) driver. Signed-off-by: Zhaoxiang Jin <[email protected]>

1. add pmc-tmpsns to rt7xx dts 2. add pmc-tmpsns to rt700 evk Signed-off-by: Zhaoxiang Jin <[email protected]>

enable rt700 die_temp_polling sample Signed-off-by: Zhaoxiang Jin <[email protected]>

ZhaoxiangJin · 2025-10-08T04:25:05Z

rebased to main, ci issue should be fixed in main.

ZhaoxiangJin · 2025-10-08T09:31:36Z

Hello @hakehuang, I see #97020 is closed, I tried to rebase to the latest main, but the CI show new failures, could you please help check again? Thanks!

hakehuang · 2025-10-09T07:35:27Z

@ZhaoxiangJin all RT700 testing is blocked by #96718, I would suggest to block all RT700 PRs until this gets resolved.
also, CI issue is same root cause as:
#97243

hakehuang · 2025-10-09T07:42:57Z

drivers/sensor/nxp/nxp_pmc_tmpsns/nxp_pmc_tmpsns.c

+
+	cm_vref = cm_ctat + (953.36f + calibration) * cm_temp / 2048;
+
+	data->pmc_tmpsns_value = 370.98f * (cm_temp / cm_vref) - 273.15f;


I would suggest to remove the float calculation above and change to int32 instead.

I'd like to know your starting point of the suggestion, actually this driver will only be used by RT500, RT600, and RT700, which all have FPU, so I think it is necessary to maintain accuracy as much as possible during the calculation process.

ZhaoxiangJin force-pushed the enable-temperature-sensor-on-rt700 branch from aa65fbd to aa11bf2 Compare September 8, 2025 03:32

github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Sep 8, 2025

ZhaoxiangJin force-pushed the enable-temperature-sensor-on-rt700 branch 3 times, most recently from 604ed81 to cb2e633 Compare September 8, 2025 04:40

ZhaoxiangJin marked this pull request as ready for review September 8, 2025 05:32

zephyrbot added area: Samples Samples platform: NXP NXP platform: NXP Drivers NXP Semiconductors, drivers area: Sensors Sensors labels Sep 8, 2025

zephyrbot requested review from avisconti, butok, dbaluta, decsny, DerekSnell, dleach02, EmilioCBen, jeppenodgaard, manuargue, MaureenHelm, mmahadevan108, teburd, tristan-google, ubieda and yperess September 8, 2025 05:33

zephyrbot assigned MaureenHelm Sep 8, 2025

ZhaoxiangJin force-pushed the enable-temperature-sensor-on-rt700 branch from cb2e633 to 65b5238 Compare September 14, 2025 14:44

github-actions bot removed manifest manifest-hal_nxp labels Sep 26, 2025

MaureenHelm reviewed Sep 29, 2025

View reviewed changes

ZhaoxiangJin force-pushed the enable-temperature-sensor-on-rt700 branch from 645d098 to a1a07f9 Compare September 29, 2025 22:17

zephyrbot added area: Boards/SoCs area: Devicetree Bindings labels Sep 29, 2025

zephyrbot requested a review from MaureenHelm September 29, 2025 22:19

jeppenodgaard requested changes Sep 30, 2025

View reviewed changes

ZhaoxiangJin force-pushed the enable-temperature-sensor-on-rt700 branch 2 times, most recently from 830dbdd to 1fa40eb Compare October 3, 2025 12:04

MaureenHelm reviewed Oct 3, 2025

View reviewed changes

JarmouniA mentioned this pull request Oct 7, 2025

modules: mcuboot: Fix missing chosen node lookup #97047

Merged

ZhaoxiangJin added 4 commits October 8, 2025 12:18

modules: hal_nxp: Pull in romapi for RT7xx

36ac574

Pull in romapi for RT7xx Signed-off-by: Zhaoxiang Jin <[email protected]>

drivers: sensor: Enable NXP pmc tmpsns driver

f4c8e52

This commit introduced NXP pmc temperature sensor (pmc-tmpsns) driver. Signed-off-by: Zhaoxiang Jin <[email protected]>

dts: nxp: add pmc-tmpsns to rt7xx dts

7fb85b2

1. add pmc-tmpsns to rt7xx dts 2. add pmc-tmpsns to rt700 evk Signed-off-by: Zhaoxiang Jin <[email protected]>

samples: enable rt700 die_temp_polling sample

e57e5fd

enable rt700 die_temp_polling sample Signed-off-by: Zhaoxiang Jin <[email protected]>

ZhaoxiangJin force-pushed the enable-temperature-sensor-on-rt700 branch from 1fa40eb to e57e5fd Compare October 8, 2025 04:23

zephyrbot requested a review from MaureenHelm October 8, 2025 04:24

ZhaoxiangJin mentioned this pull request Oct 9, 2025

update hal_nxp to mcux sdk 25.09.00 #97158

Open

hakehuang reviewed Oct 9, 2025

View reviewed changes


		cm_vref = cm_ctat + (953.36f + calibration) * cm_temp / 2048;

		data->pmc_tmpsns_value = 370.98f * (cm_temp / cm_vref) - 273.15f;

Enable temperature sensor on rt700 #95630

Are you sure you want to change the base?

Enable temperature sensor on rt700 #95630

Uh oh!

Conversation

ZhaoxiangJin commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhaoxiangJin commented Sep 26, 2025

Uh oh!

MaureenHelm Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

ZhaoxiangJin Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

ZhaoxiangJin commented Sep 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZhaoxiangJin commented Oct 3, 2025

Uh oh!

sonarqubecloud bot commented Oct 3, 2025

Quality Gate passed

Uh oh!

jeppenodgaard commented Oct 3, 2025

Uh oh!

MaureenHelm left a comment

Choose a reason for hiding this comment

Uh oh!

ZhaoxiangJin commented Oct 3, 2025

Uh oh!

hakehuang commented Oct 5, 2025

Uh oh!

ZhaoxiangJin commented Oct 8, 2025

Uh oh!

ZhaoxiangJin commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hakehuang commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hakehuang Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

ZhaoxiangJin Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ZhaoxiangJin commented Sep 8, 2025 •

edited

Loading

github-actions bot commented Sep 8, 2025 •

edited

Loading

ZhaoxiangJin commented Oct 8, 2025 •

edited

Loading

hakehuang commented Oct 9, 2025 •

edited

Loading