sd: disk ioctl get card cid command #66460 #95644
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what is the use case where you need the card ID? |
|
Same as #66460: it's often useful in logging devices to capture the CID data for traceability. Serial number can be used to track the same card between devices/if it's swapped. Manufacturer ID, product ID, application ID and date can be used to identify bad cards or a failing batch. |
tuna-f1sh
force-pushed
the
disk-io-get-cid
branch
from
6372c1d to
b09cf78
Compare
decsny
previously approved these changes
Sep 15, 2025
|
Thanks. I've pushed another commit considering this (can fixup once happy):
This means there should be no changes to RAM usage. Could expose the |
tuna-f1sh
force-pushed
the
disk-io-get-cid
branch
2 times, most recently
from
81e838c to
12a0109
Compare
decsny
reviewed
Sep 19, 2025
tuna-f1sh
force-pushed
the
disk-io-get-cid
branch
from
12a0109 to
2df3024
Compare
CID (card id register) can be useful to application for traceability of SD cards. Adds disk ioctl command to get the CID data that is read at initialisation. The struct sd_cid is moved to sd_card so that it can be read and retrieved by card_ioctrl. Signed-off-by: John Whittington <[email protected]>
CID (card id register) can be useful to application for traceability of SD cards (zephyrproject-rtos#66460). Adds disk ioctl command to get the CID data that is read at initialisation. Changes the card_read_cid function to take pointer to cid register so that the ioctl command can utilize with the passed user buf. Updated calling functions to pass this pointer. Signed-off-by: John Whittington <[email protected]>
tuna-f1sh
force-pushed
the
disk-io-get-cid
branch
from
2df3024 to
f8080f0
Compare
|
Re-based to main |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also wanted access to card CID (#66460) so added a disk ioctl command to retrieve this - cached in
sd_card structrather than stack incard_read_cid.Some option questions/opinions:
struct sd_cidcould be behind theCONFIG_SDMMC_STACK.. guard since it's only used in this case.