Skip to content

Conversation

@wm-eisos
Copy link
Contributor

@wm-eisos wm-eisos commented Sep 8, 2025

Add wsen_pdms_25131308XXX05 driver.

@mah-eiSmart

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_wurthelektronik zephyrproject-rtos/hal_wurthelektronik@e3e2797 zephyrproject-rtos/hal_wurthelektronik@7c1297e (zephyr) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest-hal_wurthelektronik DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Sep 8, 2025
@wm-eisos wm-eisos force-pushed the wsen_pdms_25131308XXX05 branch from ed700de to e40fb22 Compare September 9, 2025 08:27
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Sep 9, 2025
@wm-eisos wm-eisos force-pushed the wsen_pdms_25131308XXX05 branch 2 times, most recently from 3c6c6da to a9feb1d Compare September 9, 2025 09:16
@wm-eisos
Copy link
Contributor Author

wm-eisos commented Sep 9, 2025

@kartben the tests are failing due to some issues in bluetooth. Can you please check it out ?

@kartben
Copy link
Contributor

kartben commented Sep 9, 2025

@kartben the tests are failing due to some issues in bluetooth. Can you please check it out ?

Some of the issues are yours, I think, now that I re-ran the CI on top of main where the BT issue has been fixed:)

@kartben kartben requested a review from Copilot September 9, 2025 10:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new sensor driver for the Würth Elektronik WSEN-PDMS-25131308XXX05 differential pressure sensor, supporting both I2C and SPI interfaces with optional CRC functionality.

  • Adds complete driver implementation with initialization, sampling, and channel reading functions
  • Supports multiple sensor variants with different pressure ranges through device tree configuration
  • Updates HAL module revision and includes necessary device tree bindings and build configurations

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
west.yml Updates hal_wurthelektronik revision to include new sensor support
tests/drivers/build_all/sensor/i2c.dtsi Adds test device tree entry for build verification
dts/bindings/sensor/we,wsen-pdms-25131308XXX05-*.yaml Device tree binding files for I2C, SPI, and common properties
drivers/sensor/wsen/wsen_pdms_25131308XXX05/* Complete driver implementation with header, source, Kconfig, and CMakeLists
drivers/sensor/wsen/wsen_*/*.h Updates header includes to use new HAL structure
drivers/sensor/wsen/{Kconfig,CMakeLists.txt} Integrates new driver into build system

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Sep 9, 2025

@kartben the tests are failing due to some issues in bluetooth. Can you please check it out ?

Some of the issues are yours, I think, now that I re-ran the CI on top of main where the BT issue has been fixed:)

im not sure the test that just failed was regarding a bash script which couldnt run. unless im messing something if yes do you mind pointing it out.

I will check the review from copilot now.

@kartben
Copy link
Contributor

kartben commented Sep 9, 2025

@kartben the tests are failing due to some issues in bluetooth. Can you please check it out ?

Some of the issues are yours, I think, now that I re-ran the CI on top of main where the BT issue has been fixed:)

im not sure the test that just failed was regarding a bash script which couldnt run. unless im messing something if yes do you mind pointing it out.

I will check the review from copilot now.

...

devicetree error: 'sensor-type' is marked as required in 'properties:' in /__w/zephyr/zephyr/dts/bindings/sensor/we,wsen-pdms-25131308XXX05-i2c.yaml, but does not appear in <Node /test/i2c@11112222/wsen_pdms_25131308XXX05@bc in /__w/zephyr/zephyr/tests/drivers/build_all/sensor/i2c.dtsi:1409>
CMake Error at /__w/zephyr/zephyr/cmake/modules/dts.cmake:306 (execute_process):
  execute_process failed command indexes:

...

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Sep 9, 2025

@kartben the tests are failing due to some issues in bluetooth. Can you please check it out ?

Some of the issues are yours, I think, now that I re-ran the CI on top of main where the BT issue has been fixed:)

im not sure the test that just failed was regarding a bash script which couldnt run. unless im messing something if yes do you mind pointing it out.

I will check the review from copilot now.

@kartben the tests are failing due to some issues in bluetooth. Can you please check it out ?

Some of the issues are yours, I think, now that I re-ran the CI on top of main where the BT issue has been fixed:)

im not sure the test that just failed was regarding a bash script which couldnt run. unless im messing something if yes do you mind pointing it out.
I will check the review from copilot now.

...

devicetree error: 'sensor-type' is marked as required in 'properties:' in /__w/zephyr/zephyr/dts/bindings/sensor/we,wsen-pdms-25131308XXX05-i2c.yaml, but does not appear in <Node /test/i2c@11112222/wsen_pdms_25131308XXX05@bc in /__w/zephyr/zephyr/tests/drivers/build_all/sensor/i2c.dtsi:1409>
CMake Error at /__w/zephyr/zephyr/cmake/modules/dts.cmake:306 (execute_process):
  execute_process failed command indexes:

...

perfect thank you very much

@wm-eisos wm-eisos force-pushed the wsen_pdms_25131308XXX05 branch 4 times, most recently from d17fa22 to 76fc3ed Compare September 10, 2025 11:32
mah-eiSmart
mah-eiSmart previously approved these changes Oct 15, 2025
@jhedberg jhedberg added this to the v4.3.0 milestone Oct 15, 2025
@wm-eisos wm-eisos force-pushed the wsen_pdms_25131308XXX05 branch from 0b7dbad to fd2c63e Compare October 20, 2025 06:12
@zephyrbot zephyrbot added platform: Infineon Infineon Technologies AG platform: Renesas Renesas platform: ESP32 Espressif ESP32 area: TF-A ARM Trusted Firmware-A (TF-A) labels Oct 20, 2025
@wm-eisos wm-eisos force-pushed the wsen_pdms_25131308XXX05 branch from fd2c63e to 1d399db Compare October 20, 2025 06:28
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased, but otherwise LGTM

MaureenHelm
MaureenHelm previously approved these changes Oct 21, 2025
@wm-eisos
Copy link
Contributor Author

@MaureenHelm @kartben ready to be merged

MaureenHelm
MaureenHelm previously approved these changes Oct 22, 2025
Update the hal to have the latest Sensors SDK
version 2.7.0

Signed-off-by: Wajdi ELMuhtadi <[email protected]>
Add wsen_pdms_25131308XXX05 driver.

Signed-off-by: Wajdi ELMuhtadi <[email protected]>
@wm-eisos
Copy link
Contributor Author

@MaureenHelm @kartben needs another approval because of the i2c test conflict. Is there a way we can resolve the issue with this should i start using the last I2C address+5 or should i keep them contiguous?

@sonarqubecloud
Copy link

Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaureenHelm @kartben needs another approval because of the i2c test conflict. Is there a way we can resolve the issue with this should i start using the last I2C address+5 or should i keep them contiguous?

No, please don't do that. It might help for one PR, but if everyone starts doing that then we'll just shift the address conflict by 5. I've thought about trying to extract the nodes into separate buses for each vendor, but haven't gotten around to doing it and you're welcome to take a stab at it if you like.

@jhedberg jhedberg merged commit ffdf184 into zephyrproject-rtos:main Oct 23, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs area: Devicetree Bindings area: Sensors Sensors area: Tests Issues related to a particular existing or missing test area: TF-A ARM Trusted Firmware-A (TF-A) manifest manifest-hal_wurthelektronik platform: ESP32 Espressif ESP32 platform: Infineon Infineon Technologies AG platform: Renesas Renesas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants