-
Notifications
You must be signed in to change notification settings - Fork 8.1k
drivers: sensor: wsen_pdms_25131308XXX05: add sensor driver #95673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: sensor: wsen_pdms_25131308XXX05: add sensor driver #95673
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
ed700de to
e40fb22
Compare
3c6c6da to
a9feb1d
Compare
|
@kartben the tests are failing due to some issues in bluetooth. Can you please check it out ? |
Some of the issues are yours, I think, now that I re-ran the CI on top of main where the BT issue has been fixed:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new sensor driver for the Würth Elektronik WSEN-PDMS-25131308XXX05 differential pressure sensor, supporting both I2C and SPI interfaces with optional CRC functionality.
- Adds complete driver implementation with initialization, sampling, and channel reading functions
- Supports multiple sensor variants with different pressure ranges through device tree configuration
- Updates HAL module revision and includes necessary device tree bindings and build configurations
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
west.yml |
Updates hal_wurthelektronik revision to include new sensor support |
tests/drivers/build_all/sensor/i2c.dtsi |
Adds test device tree entry for build verification |
dts/bindings/sensor/we,wsen-pdms-25131308XXX05-*.yaml |
Device tree binding files for I2C, SPI, and common properties |
drivers/sensor/wsen/wsen_pdms_25131308XXX05/* |
Complete driver implementation with header, source, Kconfig, and CMakeLists |
drivers/sensor/wsen/wsen_*/*.h |
Updates header includes to use new HAL structure |
drivers/sensor/wsen/{Kconfig,CMakeLists.txt} |
Integrates new driver into build system |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
drivers/sensor/wsen/wsen_pdms_25131308XXX05/wsen_pdms_25131308XXX05.c
Outdated
Show resolved
Hide resolved
im not sure the test that just failed was regarding a bash script which couldnt run. unless im messing something if yes do you mind pointing it out. I will check the review from copilot now. |
|
im not sure the test that just failed was regarding a bash script which couldnt run. unless im messing something if yes do you mind pointing it out. I will check the review from copilot now.
perfect thank you very much |
d17fa22 to
76fc3ed
Compare
0b7dbad to
fd2c63e
Compare
fd2c63e to
1d399db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be rebased, but otherwise LGTM
1d399db to
f48ed40
Compare
|
@MaureenHelm @kartben ready to be merged |
Update the hal to have the latest Sensors SDK version 2.7.0 Signed-off-by: Wajdi ELMuhtadi <[email protected]>
Add wsen_pdms_25131308XXX05 driver. Signed-off-by: Wajdi ELMuhtadi <[email protected]>
f48ed40 to
430fbab
Compare
|
@MaureenHelm @kartben needs another approval because of the i2c test conflict. Is there a way we can resolve the issue with this should i start using the last I2C address+5 or should i keep them contiguous? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaureenHelm @kartben needs another approval because of the i2c test conflict. Is there a way we can resolve the issue with this should i start using the last I2C address+5 or should i keep them contiguous?
No, please don't do that. It might help for one PR, but if everyone starts doing that then we'll just shift the address conflict by 5. I've thought about trying to extract the nodes into separate buses for each vendor, but haven't gotten around to doing it and you're welcome to take a stab at it if you like.



Add wsen_pdms_25131308XXX05 driver.
@mah-eiSmart