Skip to content

Conversation

hengrun
Copy link

@hengrun hengrun commented Sep 12, 2025

Add ARMv8 ITM to lpc55S2x common device tree and set the clock config when using SWO as a logging backend.

Copy link

Hello @hengrun, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@dleach02
Copy link
Member

@hengrun Thank you for your contribution. You have a compliance issue that needs to be resolved. All the commit messages need to have header and body with signoff.

@dleach02
Copy link
Member

dleach02 commented Oct 13, 2025

@hengrun we can not move forward on this PR until you address the compliance issue. And please address the merge conflict

https://docs.zephyrproject.org/latest/contribute/guidelines.html#pull-request-guidelines

Add ITM to common device tree and set the correct clock config when using SWO as a logging backend

Signed-off-by: Henrik Grunmach <[email protected]>
Copy link

@dleach02
Copy link
Member

Your commit 5492b0b with title "Merge branch 'main' into add-swo-lpc55" is the problem. Amend the commit to fix the title and description to align with Zephyr guidelines: https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants