Skip to content

drivers: display: Update ST7567 to use MIPI-DBI #95927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2025
Merged

drivers: display: Update ST7567 to use MIPI-DBI #95927

merged 2 commits into from
Oct 9, 2025

Conversation

VynDragon
Copy link
Contributor

Allows ST7567 to use dbi controller

@VynDragon VynDragon force-pushed the st7567_dbi branch 2 times, most recently from e04379c to 005fab3 Compare September 12, 2025 20:38
@VynDragon VynDragon marked this pull request as ready for review September 12, 2025 20:57
JarmouniA
JarmouniA previously approved these changes Sep 12, 2025
View reviewed changes
@VynDragon VynDragon requested a review from JarmouniA September 13, 2025 13:39
@VynDragon VynDragon mentioned this pull request Sep 18, 2025
Open
jeremydick
jeremydick suggested changes Sep 18, 2025
View reviewed changes
JarmouniA
JarmouniA previously approved these changes Sep 18, 2025
View reviewed changes
josuah
josuah previously approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue found anywhere here...
Thanks for the maintenance!

[EDIT: just a merge conflict now]

@kartben
Copy link
Contributor

kartben commented Oct 8, 2025

@VynDragon please rebase

@VynDragon VynDragon dismissed stale reviews from josuah and JarmouniA via 1ad9f6c October 8, 2025 11:26
@VynDragon VynDragon requested review from JarmouniA and josuah October 8, 2025 11:27
josuah
josuah previously approved these changes Oct 8, 2025
View reviewed changes
JarmouniA
JarmouniA previously approved these changes Oct 8, 2025
View reviewed changes
@VynDragon
Copy link
Contributor Author

Guys i forgot the tests, DNM.

@VynDragon VynDragon added the DNM This PR should not be merged (Do Not Merge) label Oct 8, 2025
@VynDragon VynDragon requested review from josuah and JarmouniA October 8, 2025 15:33
JarmouniA
JarmouniA previously approved these changes Oct 8, 2025
View reviewed changes
josuah
josuah previously approved these changes Oct 8, 2025
View reviewed changes
@cfriedt
Copy link
Member

cfriedt commented Oct 8, 2025

@VynDragon - needs a rebase to fix merge conflicts.

@VynDragon VynDragon dismissed stale reviews from josuah and JarmouniA via 5e8e505 October 9, 2025 01:42
@VynDragon VynDragon requested review from josuah and JarmouniA October 9, 2025 01:42
josuah
josuah previously approved these changes Oct 9, 2025
View reviewed changes
@nashif nashif removed their assignment Oct 9, 2025
@nashif
Copy link
Member

nashif commented Oct 9, 2025

image

@JarmouniA Maybe you want to make youself maintainer of this area? :) Please submit a change to the maintainer file...

JarmouniA
JarmouniA reviewed Oct 9, 2025
View reviewed changes
@VynDragon
drivers: display: Update ST7567 to use MIPI-DBI
e8c0e1f 
Allows ST7567 to use dbi controller

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon
tests: drivers: build_all: add st7567 mipi-dbi
8c37b79 
Adds the test for st7567 on mipi-dbi

Signed-off-by: Camille BAUD <[email protected]>
@VynDragon VynDragon requested review from josuah and JarmouniA October 9, 2025 14:36
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@VynDragon
Copy link
Contributor Author

VynDragon commented Oct 9, 2025 •
edited
Loading

@JarmouniA looks like github didnt take your approval into account?

Edit: view from side after ctrl+F5:
image
View from bottom:
image

and it's absent from merge list

@VynDragon
Copy link
Contributor Author

That fixed it 👍

@cfriedt cfriedt merged commit 4dd6976 into zephyrproject-rtos:main Oct 9, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarmouniA JarmouniA JarmouniA approved these changes

@josuah josuah josuah approved these changes

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@nashif nashif Awaiting requested review from nashif

+1 more reviewer

@jeremydick jeremydick jeremydick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@JarmouniA JarmouniA

Labels
area: Boards/SoCs area: Devicetree Bindings area: Display area: Tests Issues related to a particular existing or missing test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VynDragon @kartben @josuah @cfriedt @nashif @jeremydick @JarmouniA @zephyrbot