boards: Add sparkfun samd21 dev breakout board #95971
Conversation
ricfehr3
force-pushed
the
add_sparkfun_samd21
branch
from
c65f67e to
d83ba75
Compare
boards/sparkfun/samd21_dev_breakout/sparkfun_samd21_breakout.dts
Outdated
Show resolved
Hide resolved
boards/sparkfun/samd21_dev_breakout/sparkfun_samd21_breakout.dts
Outdated
Show resolved
Hide resolved
boards/sparkfun/samd21_dev_breakout/sparkfun_samd21_breakout_connector.dtsi
Outdated
Show resolved
Hide resolved
ricfehr3
force-pushed
the
add_sparkfun_samd21
branch
5 times, most recently
from
fdd460b to
e15fdc2
Compare
| @@ -0,0 +1,20 @@ | |||
| identifier: sparkfun_samd21_breakout | |||
| name: Sparkfun SAMD21 Deb Breakout | |||
ricfehr3
force-pushed
the
add_sparkfun_samd21
branch
from
e15fdc2 to
9799a99
Compare
|
Sorry, did a force push to try to fix that compliance issue. Working through the PR comments now. |
ricfehr3
force-pushed
the
add_sparkfun_samd21
branch
2 times, most recently
from
27f7f49 to
29725ea
Compare
|
@kartben Applied your doc suggestions and the other fixes. All rebased and should pass compliance now 👍 |
ricfehr3
force-pushed
the
add_sparkfun_samd21
branch
from
29725ea to
843f960
Compare
Thanks! And this last push should actually be good. |
ricfehr3
force-pushed
the
add_sparkfun_samd21
branch
from
843f960 to
9d32963
Compare
|
Hey, could I bump this to get merged? |
ricfehr3
force-pushed
the
add_sparkfun_samd21
branch
from
9d32963 to
fd540b2
Compare
|
@kartben Not to bug you, but can I bump for a merge :) |
|
Hey, hate to bump this again if it's too much trouble. Looks like one of the reviewers may be on vacation. |
boards/sparkfun/samd21_dev_breakout/doc/img/sparkfun_samd21_breakout.webp
Show resolved
Hide resolved
|
@ricfehr3 I am really sorry that this fell through the cracks -- please have a look at the last few outstanding comments and I'll make sure to help push this over the finish line. I've removed @martinjaeger as assignee since there is hardly anything about DAC in this PR. Thanks for your patience! |
|
No problem at all, thanks for helping out! |
ricfehr3
force-pushed
the
add_sparkfun_samd21
branch
from
fd540b2 to
0f31e4a
Compare
Thanks for picking this up again so quickly. I applied your suggested changes. |
zephyrbot
added
area: Boards/SoCs
area: Tests
Adding the sparkfun samd21 dev breakout board. This will work with the basic blinky sample. Link attached to the boards info page. Link: https://www.sparkfun.com/sparkfun-samd21-dev-breakout.html Signed-off-by: Rickey Fehr <[email protected]>
ricfehr3
force-pushed
the
add_sparkfun_samd21
branch
from
0f31e4a to
9503d15
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
Hi @ricfehr3! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
6 participants
Adding the sparkfun samd21 dev breakout board. This will work with the basic blinky sample. Link attached to the boards info page.
Link: https://www.sparkfun.com/sparkfun-samd21-dev-breakout.html
I made a guide on the work I did too: https://rf3.xyz/posts/zephyr-porting-guide/