Skip to content

Conversation

fimohame
Copy link
Contributor

This commit enables the pm device driver support for the i2s_silabs_siwx91x driver.

@fimohame fimohame marked this pull request as ready for review September 15, 2025 14:53
@fimohame fimohame marked this pull request as draft September 24, 2025 21:25
@fimohame fimohame force-pushed the device_pm_silabs_i2s_siwx91x branch 2 times, most recently from 9867114 to 954f233 Compare September 24, 2025 22:13
@fimohame fimohame marked this pull request as ready for review September 25, 2025 07:24
Copy link
Member

@Martinhoff-maker Martinhoff-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you test it ? I have tried to compile the i2s output sample with the PM config and it does not compile for me.

@fimohame
Copy link
Contributor Author

fimohame commented Oct 6, 2025

I had created an test app locally which basically does i2s output with few overlay and prj.conf changes.

For the concern raised I have also validated with the i2s output test app,
find below the configurations i had used for reference

I2S pm changes requires the DMA PM commits: #94374

In overlay

/ {
	aliases {
		i2s-tx = &i2s0;
	};
};

&pinctrl0 {
	i2s0_default: i2s0_default {
		out {
			/* I2S0_CLK_HP25 - P25,  I2S0_DOUT0_HP28 - P31, I2S0_WS_HP26 - P27*/
			pinmux = <I2S0_CLK_HP25>, <I2S0_DOUT0_HP28>, <I2S0_WS_HP26>;
		};
		in {
			/* I2S0_DIN0_HP27 - P29 */
			pinmux = <I2S0_DIN0_HP27>;
		};
	};
};

&i2s0 {
	status = "okay";
	pinctrl-0 = <&i2s0_default>;
	pinctrl-names = "default";
	**zephyr,pm-device-runtime-auto;**
	dmas = <&dma0 15>, <&dma0 14>;
	dma-names = "tx", "rx";
};
&nwp {
    power-profile = "deep-sleep-with-ram-retention";
    status = "okay";
};
&dma0 {
	zephyr,pm-device-runtime-auto;
	status = "okay";
};

prj.conf

CONFIG_I2S=y
CONFIG_PM=y
CONFIG_PM_DEVICE=y
CONFIG_POWER_DOMAIN=y
CONFIG_NETWORKING=y
CONFIG_WIFI=y
CONFIG_I2S_SILABS_SIWX91X_TX_BLOCK_COUNT=20

@fimohame fimohame force-pushed the device_pm_silabs_i2s_siwx91x branch from 954f233 to 3c518ca Compare October 17, 2025 04:42
@fimohame fimohame force-pushed the device_pm_silabs_i2s_siwx91x branch from 3c518ca to 5012468 Compare October 17, 2025 05:26
This commit enables the pm device driver support
for the i2s_silabs_siwx91x driver.

Signed-off-by: S Mohamed Fiaz <[email protected]>
@fimohame fimohame force-pushed the device_pm_silabs_i2s_siwx91x branch from 5012468 to 788fef9 Compare October 17, 2025 07:12
Copy link

@Martinhoff-maker
Copy link
Member

feels ok now but needs to wait for the DMA PR to be merged in order to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants