Skip to content

Conversation

sviviani-nordicsemi
Copy link
Contributor

The ssd1396 shield uses an I2C interface, and the nrf5340dk board overlay needs a bigger buffer size by default to work. It also needs to enable a default theme if using LVGL and display is monochrome (1 bit depth)

Signed-off-by: Sebastian Viviani <[email protected]

Copy link

Hello @sviviani-nordicsemi, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added the area: Shields Shields (add-on boards) label Sep 15, 2025
@sviviani-nordicsemi sviviani-nordicsemi force-pushed the lvgl_basic_sample_for_5340DK_ssd1306shield branch 3 times, most recently from c4ce3da to 2c15f68 Compare September 17, 2025 10:10
@zephyrbot zephyrbot added the area: LVGL Light and Versatile Graphics Library Support label Sep 17, 2025
@sviviani-nordicsemi sviviani-nordicsemi force-pushed the lvgl_basic_sample_for_5340DK_ssd1306shield branch from 2c15f68 to 840f3e1 Compare September 22, 2025 10:31
@sviviani-nordicsemi sviviani-nordicsemi force-pushed the lvgl_basic_sample_for_5340DK_ssd1306shield branch from 840f3e1 to 21d4f02 Compare September 28, 2025 19:14
@sviviani-nordicsemi
Copy link
Contributor Author

I see some tests are failing, but not sure if it is related to these changes? Can anybody help with some context of what would be the normal Zephyr merge procedure? Should I rebase to latest main and push again?

@faxe1008
Copy link
Contributor

faxe1008 commented Oct 6, 2025

You can rebase, but that will discard all approvals. I retriggered the failed steps, maybe thats enough

@pdgendt
Copy link
Contributor

pdgendt commented Oct 6, 2025

You can rebase, but that will discard all approvals. I retriggered the failed steps, maybe thats enough

Rebasing does not dismiss approvals, if nothing else is changed.

@faxe1008
Copy link
Contributor

faxe1008 commented Oct 7, 2025

Yeah seems like you have to rebase to pull the CI fixes in regards to the new python depedencies.

@sviviani-nordicsemi sviviani-nordicsemi force-pushed the lvgl_basic_sample_for_5340DK_ssd1306shield branch from 21d4f02 to 8cc857e Compare October 7, 2025 08:09
@kartben
Copy link
Contributor

kartben commented Oct 8, 2025

Commit message is stale, please update it. Thanks!

The ssd1396 shield uses an I2C interface, and the nrf5340dk board
overlay needs a bigger buffer size by default to work.

Signed-off-by: Sebastian Viviani <[email protected]>
@sviviani-nordicsemi sviviani-nordicsemi force-pushed the lvgl_basic_sample_for_5340DK_ssd1306shield branch from 8cc857e to 494c892 Compare October 9, 2025 06:42
Copy link

sonarqubecloud bot commented Oct 9, 2025

@kartben kartben merged commit 77e4752 into zephyrproject-rtos:main Oct 13, 2025
26 checks passed
Copy link

Hi @sviviani-nordicsemi!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs area: LVGL Light and Versatile Graphics Library Support area: Shields Shields (add-on boards)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants