-
Notifications
You must be signed in to change notification settings - Fork 8k
shields: support for ssd1306 shield on nrf5340dk #96021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shields: support for ssd1306 shield on nrf5340dk #96021
Conversation
Hello @sviviani-nordicsemi, and thank you very much for your first pull request to the Zephyr project! |
c4ce3da
to
2c15f68
Compare
2c15f68
to
840f3e1
Compare
840f3e1
to
21d4f02
Compare
I see some tests are failing, but not sure if it is related to these changes? Can anybody help with some context of what would be the normal Zephyr merge procedure? Should I rebase to latest main and push again? |
You can rebase, but that will discard all approvals. I retriggered the failed steps, maybe thats enough |
Rebasing does not dismiss approvals, if nothing else is changed. |
Yeah seems like you have to rebase to pull the CI fixes in regards to the new python depedencies. |
21d4f02
to
8cc857e
Compare
Commit message is stale, please update it. Thanks! |
The ssd1396 shield uses an I2C interface, and the nrf5340dk board overlay needs a bigger buffer size by default to work. Signed-off-by: Sebastian Viviani <[email protected]>
8cc857e
to
494c892
Compare
|
Hi @sviviani-nordicsemi! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
The ssd1396 shield uses an I2C interface, and the nrf5340dk board overlay needs a bigger buffer size by default to work. It also needs to enable a default theme if using LVGL and display is monochrome (1 bit depth)
Signed-off-by: Sebastian Viviani <[email protected]