Skip to content

boards: nxp: mimxrt1170: Remove SYSBUILD in board.cmake #96038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

boards: nxp: mimxrt1170: Remove SYSBUILD in board.cmake #96038

merged 1 commit into from
Sep 17, 2025

Conversation

@EmilioCBen
Copy link
Contributor

@EmilioCBen EmilioCBen commented Sep 15, 2025

Removed the dependency of config sysbuild from
the mimxrt1170_evk board.cmake.

@EmilioCBen
boards: nxp: mimxrt1170: Remove SYSBUILD in board.cmake
a019306 
Removed the dependency of config sysbuild from
the mimxrt1170_evk board.cmake.

Signed-off-by: Emilio Benavente <[email protected]>
@EmilioCBen EmilioCBen requested a review from nordicjm September 15, 2025 20:00
@EmilioCBen EmilioCBen added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Sep 15, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@EmilioCBen EmilioCBen mentioned this pull request Sep 15, 2025
Open
1 task
henrikbrixandersen
henrikbrixandersen requested changes Sep 17, 2025
View reviewed changes
@decsny
Copy link
Member

decsny commented Sep 17, 2025 •
edited
Loading

Is this fixing an issue? The commit message does not give any context or motivation of the change. There must have been a reason someone said not to reset when doing sysbuild before? Can you explain what was their reasoning and why it was wrong?

@EmilioCBen
Copy link
Contributor Author

EmilioCBen commented Sep 17, 2025

Is this fixing an issue? The commit message does not give any context or motivation of the change. There must have been a reason someone said not to reset when doing sysbuild before? Can you explain what was their reasoning and why it was wrong?

@nordicjm I will need your input here.

@nordicjm
Copy link
Contributor

nordicjm commented Sep 17, 2025

Is this fixing an issue? The commit message does not give any context or motivation of the change. There must have been a reason someone said not to reset when doing sysbuild before? Can you explain what was their reasoning and why it was wrong?

Using sysbuild should play no part in e.g. flashing, if you can flash one image normally without sysbuild, then you can flash one or more with sysbuild

@kartben kartben merged commit d7857b0 into zephyrproject-rtos:main Sep 17, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@dleach02 dleach02 dleach02 approved these changes

@nordicjm nordicjm nordicjm approved these changes

@butok butok Awaiting requested review from butok

@decsny decsny Awaiting requested review from decsny

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels

platform: NXP NXP Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@EmilioCBen @decsny @nordicjm @henrikbrixandersen @dleach02 @kartben @mmahadevan108 @zephyrbot