Skip to content

drivers: flash: mchp: Introduce G1 Flash Driver #96075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 23, 2025
Merged

drivers: flash: mchp: Introduce G1 Flash Driver #96075

merged 5 commits into from
Oct 23, 2025

Conversation

@fabin-mchp
Copy link
Contributor

This pull request adds flash driver support for the Microchip NVMCTRL peripheral. It includes the implementation of the flash driver and updates the device tree for the SAM D5/E5 series to include the necessary node and bindings for the Microchip Nonvolatile Memory Controller (NVMCTRL).

@github-actions
Copy link

Hello @fabin-mchp, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added platform: Microchip MEC Microchip MEC Platform platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) area: Flash labels Sep 16, 2025
@nandojve nandojve added this to the v4.3.0 milestone Sep 16, 2025
@nandojve nandojve self-assigned this Sep 16, 2025
@nandojve nandojve changed the title Add Microchip G1 Flash Driver Support for NVMCTRL Peripheral drivers: flash: mchp: Introduce G1 Flash Driver Sep 16, 2025
nandojve
nandojve requested changes Sep 16, 2025
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabin-mchp ,

I did not have time to look in the driver code yet.
I'll look on this soon.

@fabin-mchp fabin-mchp force-pushed the g1_flash_driver branch 2 times, most recently from 58ea739 to 61dacea Compare September 19, 2025 13:20
nandojve
nandojve requested changes Sep 19, 2025
View reviewed changes
@zephyrbot zephyrbot requested a review from nandojve September 23, 2025 07:01
nordicjm
nordicjm requested changes Sep 23, 2025
View reviewed changes
soc/microchip/sam/sam_d5x_e5x/Kconfig.soc Outdated
Comment on lines 13 to 17
config FLASH_MCHP_NVMCTRL_U2409_1_0_0
bool
default y
help
Enable FLASH peripheral IP version 1.0.0 (U2409).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not put these in Kconfig.soc, they would go in Kconfig, and actually now I'm looking at it, what even is this symbol for? You know in dts if this peripheral exists and is enabled, why does it need yet another symbol?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nordicjm Based on your feedback in this comment from another PR, I am removing the symbol as suggested.

nordicjm
nordicjm previously approved these changes Sep 25, 2025
View reviewed changes
@albertofloyd albertofloyd removed their request for review October 9, 2025 19:01
@NhMchp NhMchp self-requested a review October 13, 2025 06:39
NhMchp
NhMchp previously approved these changes Oct 13, 2025
View reviewed changes
@fabin-mchp fabin-mchp dismissed stale reviews from NhMchp and nordicjm via e3d9142 October 17, 2025 07:12
@zephyrbot zephyrbot requested a review from nashif October 17, 2025 07:13
NhMchp
NhMchp requested changes Oct 19, 2025
View reviewed changes
@nandojve
Copy link
Member

Hi @fabin-mchp ,

Could you fix Niyas comments and rebase on top of main ? I would like to see if the CI error will disappear.

@fabin-mchp
Copy link
Contributor Author

Hi @fabin-mchp ,

Could you fix Niyas comments and rebase on top of main ? I would like to see if the CI error will disappear.

Hi @nandojve,

I have fixed the comments provided by Niyas and rebased the branch on top of main.

@fabin-mchp fabin-mchp requested a review from NhMchp October 23, 2025 07:39
@fabin-mchp
dts: arm: microchip: add flash node and bindings
fd7112b 
Add flash node and binding parameters for nvmctrl
flash driver

Signed-off-by: Fabin V Martin <[email protected]>
@fabin-mchp
drivers: flash: microchip: add flash g1 driver
d19a004 
Add flash driver for Microchip NVMCTRL g1

Signed-off-by: Fabin V Martin <[email protected]>
@fabin-mchp
boards: microchip: Update sam_e54_xpro device tree
2a7ac7d 
Add zephyr,flash-controller to the chosen node and
add partitions for mcuboot support

Signed-off-by: Fabin V Martin <[email protected]>
@fabin-mchp
samples: sysbuild: update list of allowed platforms
3a8d6d0 
Add sam_e54_xpro board to test mcuboot builds.

Signed-off-by: Fabin V Martin <[email protected]>
@fabin-mchp
tests: boot: test_mcuboot: Add sam_e54_xpro to platform allow list
2b526cb 
Enable mcuboot test for sam_e54_xpro board.

Signed-off-by: Fabin V Martin <[email protected]>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nandojve nandojve requested a review from nordicjm October 23, 2025 12:43
@kartben kartben merged commit ea07b16 into zephyrproject-rtos:main Oct 23, 2025
27 checks passed
@github-actions
Copy link

Hi @fabin-mchp!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nandojve nandojve nandojve approved these changes

@NhMchp NhMchp NhMchp approved these changes

@de-nordic de-nordic Awaiting requested review from de-nordic

@jvasanth1 jvasanth1 Awaiting requested review from jvasanth1

@mnkp mnkp Awaiting requested review from mnkp

@pdgendt pdgendt Awaiting requested review from pdgendt

@rghaddab rghaddab Awaiting requested review from rghaddab

@stephanosio stephanosio Awaiting requested review from stephanosio

@VenkatKotakonda VenkatKotakonda Awaiting requested review from VenkatKotakonda

@57300 57300 Awaiting requested review from 57300

@d3zd3z d3zd3z Awaiting requested review from d3zd3z

@kartben kartben Awaiting requested review from kartben

@tejlmand tejlmand Awaiting requested review from tejlmand

@nashif nashif Awaiting requested review from nashif

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@nandojve nandojve

@de-nordic de-nordic

Labels

area: Bootloader area: Flash area: MCUBoot area: Samples Samples area: Sysbuild platform: Microchip MEC Microchip MEC Platform platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

7 participants

@fabin-mchp @nandojve @nordicjm @NhMchp @kartben @zephyrbot @de-nordic