Add Qbv support, Qbv is Enhancements for Scheduled Traffic (EST) #96124

ZhaoQiang-b45475 · 2025-09-17T07:33:36Z

Add Qbv support, Qbv(IEEE 802.1Qbv) is Enhancements for Scheduled Traffic (EST), one
feature of TSN. The PTP clock provides the time reference for Qbv
In subsys/net/l2/ethernet/Kconfig, add NET_QBV config
In driver, add set_config/get_config to set and get Qbv configuration.
support enable/disable, set/get times, set/get list length and
set/get gate control list.
Add a Qbv shell cmd to set/get qbv

drivers/ethernet/Kconfig

include/zephyr/net/dsa_core.h

subsys/net/lib/shell/CMakeLists.txt

jukkar · 2025-09-17T08:16:33Z

subsys/net/lib/shell/qbv_shell.c

+	if (ret < 0) {
+		return ret;
+	}
+


For each command, we should probably verify that the interface is Ethernet type.
Why force user to use the device as a parameter if we are using interface internally? It should make things clearer if user just uses network interface index to configure Qbv.

Please do not resolve the configuration but let the reviewer do it. See https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers for details.

We should add here the interface type check, see my comment below.

yangbolu1991

See my comments for DSA part.
Thanks.

include/zephyr/net/dsa_core.h

drivers/ethernet/dsa/Kconfig

drivers/ethernet/dsa/dsa_nxp_imx_netc.c

subsys/net/lib/shell/Kconfig

subsys/net/lib/shell/qbv_shell.c

subsys/net/lib/shell/CMakeLists.txt

subsys/net/l2/ethernet/Kconfig

nashif · 2025-09-25T08:03:02Z

Support Qbv

is this for IEEE 802.1Qbv Ethernet? Can you please change the title and body with more detais?

subsys/net/l2/ethernet/Kconfig

jukkar · 2025-09-29T13:12:06Z

subsys/net/lib/shell/Kconfig

+config NET_SHELL_QBV_SUPPORTED
+	bool "Qbv Shell"
+	depends on NET_L2_ETHERNET_MGMT
+	help
+	  Enable Qbv Shell.
+	  The Qbv shell currently supports set/enable operations.


This is not what I meant. The supported option should look similar as the other options around it.

config NET_SHELL_QBV_SUPPORTED bool "Qbv shell" default y depends on NET_SHELL_SHOW_DISABLED_COMMANDS || NET_QBV

jukkar · 2025-09-29T13:16:02Z

subsys/net/lib/shell/qbv_shell.c

+	if (ret < 0) {
+		return ret;
+	}
+


Please do not resolve the configuration but let the reviewer do it. See https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers for details.

We should add here the interface type check, see my comment below.

jukkar · 2025-09-29T13:22:08Z

subsys/net/lib/shell/qbv_shell.c

+		PR_WARNING("No such interface in index %d\n", idx);
+		return -ENOEXEC;
+	}
+


What is missing here is verification that the interface is Ethernet type. That can be done like this

if (net_if_l2(iface) != &NET_L2_GET_NAME(ETHERNET)) { PR_WARNING("Qbv can be set only for Ethernet\n"); return -ENOEXEC; }

jukkar · 2025-09-29T13:23:59Z

subsys/net/lib/shell/qbv_shell.c

+		PR_WARNING("No such interface in index %d\n", idx);
+		return -ENOEXEC;
+	}
+


Interface type check should be added here too. Perhaps you could refactor code for the idx, iface and the interface type check into separate checker function and call that for each sub-shell command.

jukkar · 2025-09-29T13:28:15Z

subsys/net/lib/shell/qbv_shell.c

+/* qbv set_config <iface_index> <row> <gate_control> <interval> */
+static int cmd_qbv_set_gc(const struct shell *sh, size_t argc, char **argv)
+{
+	struct net_if *iface;


Could you change each sub-command to work like this:

static int cmd_qbv_xxx(const struct ...., ) { #if defined(CONFIG_NET_QBV) #else PR_INFO("Set %s to enable %s support.\n", "CONFIG_NET_QBV", "Qbv"); #endif }

This way user is informed what options to set if Qbv is not enabled. And the code is compiled out if CONFIG_NET_SHELL_QBV_SUPPORTED is turned off (set to n, it is y by default).

subsys/net/lib/shell/CMakeLists.txt

Supported set/get_config API. Signed-off-by: Qiang Zhao <[email protected]>

Add NET_QBV in Kconfig, Qbv is Enhancements for Scheduled Traffic (EST), one feature of TSN. The PTP clock provides the time reference for Qbv Signed-off-by: Qiang Zhao <[email protected]>

Add DSA Qbv support, add set_config/get_config to set and get Qbv configuration. support enable/disable, set/get times, set/get list length and set/get gate control list. Signed-off-by: Qiang Zhao <[email protected]>

Added Qbv shell subcommand to net command. Supported enable, set_config, set_time and get_info functions. Signed-off-by: Qiang Zhao <[email protected]>

add Qbv capability for dsa_nxp_imx_netc Signed-off-by: Qiang Zhao <[email protected]>

sonarqubecloud · 2025-10-09T07:59:27Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

drivers/ethernet/dsa/dsa_nxp_imx_netc.c

JiafeiPan · 2025-10-09T07:48:43Z

drivers/ethernet/dsa/dsa_nxp_imx_netc.c

+#ifdef CONFIG_NET_QBV
+	memset(&(prv->qbv_config[cfg->port_idx].tgs_config), 0, sizeof(netc_tb_tgs_gcl_t));
+	memset(prv->qbv_config[cfg->port_idx].gcList, 0,
+	       sizeof(netc_tgs_gate_entry_t) * CONFIG_DSA_NXP_NETC_GCL_LEN);


how about replace these two memset with the suggested code at: line 476

subsys/net/lib/shell/qbv_shell.c

JiafeiPan · 2025-10-09T08:05:08Z

drivers/ethernet/dsa/dsa_nxp_imx_netc.c

+		if (row > CONFIG_DSA_NXP_NETC_GCL_LEN) {
+			LOG_ERR("The gate control list length exceeds the limit");
+			ret = -ENOTSUP;
+		}


Suggested change

}

break;

}

will fix next version

JiafeiPan · 2025-10-09T08:06:30Z

drivers/ethernet/dsa/dsa_nxp_imx_netc.c

+		if (row > CONFIG_DSA_NXP_NETC_GCL_LEN) {
+			LOG_ERR("The gate control list length exceeds the limit");
+			ret = -ENOTSUP;
+		}


Suggested change

}

break;

}

will fix next version

zephyrbot added area: Networking platform: NXP Drivers NXP Semiconductors, drivers area: Ethernet area: DSA labels Sep 17, 2025

zephyrbot requested review from ClaCodes, JiafeiPan, dbaluta, decsny, dleach02, jukkar, lmajewski, maass-hamburg, manuargue, mmahadevan108, pdgendt, rlubos, ssharks and yangbolu1991 September 17, 2025 07:35

zephyrbot assigned rlubos and jukkar Sep 17, 2025

jukkar reviewed Sep 17, 2025

View reviewed changes

ZhaoQiang-b45475 force-pushed the support-qbv branch 2 times, most recently from 8bc2f6c to f440963 Compare September 18, 2025 03:04

zephyrbot requested a review from jukkar September 18, 2025 03:05

ZhaoQiang-b45475 force-pushed the support-qbv branch 2 times, most recently from af4702c to 95da213 Compare September 18, 2025 03:16

yangbolu1991 reviewed Sep 22, 2025

View reviewed changes

include/zephyr/net/dsa_core.h Outdated Show resolved Hide resolved

drivers/ethernet/dsa/Kconfig Show resolved Hide resolved

drivers/ethernet/dsa/dsa_nxp_imx_netc.c Show resolved Hide resolved

drivers/ethernet/dsa/dsa_nxp_imx_netc.c Outdated Show resolved Hide resolved

ZhaoQiang-b45475 force-pushed the support-qbv branch from 95da213 to cb451f7 Compare September 23, 2025 05:57

zephyrbot requested a review from yangbolu1991 September 23, 2025 05:58

ZhaoQiang-b45475 force-pushed the support-qbv branch from cb451f7 to f1b6ba5 Compare September 23, 2025 06:15

jukkar reviewed Sep 25, 2025

View reviewed changes

nashif changed the title ~~Support qbv~~ Add Qbv support, Qbv is Enhancements for Scheduled Traffic (EST) Sep 25, 2025

ZhaoQiang-b45475 force-pushed the support-qbv branch from f1b6ba5 to fb85304 Compare September 29, 2025 06:26

zephyrbot added the platform: NXP NXP label Sep 29, 2025

zephyrbot requested a review from jukkar September 29, 2025 06:27

ZhaoQiang-b45475 force-pushed the support-qbv branch 3 times, most recently from d1e9dd6 to 3bafe36 Compare September 29, 2025 07:03

jukkar reviewed Sep 29, 2025

View reviewed changes

ZhaoQiang-b45475 added 3 commits October 9, 2025 12:29

net: dsa: add set/get_config support

211c28b

Supported set/get_config API. Signed-off-by: Qiang Zhao <[email protected]>

net: ethernet: add NET_QBV Kconfig

6ec6b03

Add NET_QBV in Kconfig, Qbv is Enhancements for Scheduled Traffic (EST), one feature of TSN. The PTP clock provides the time reference for Qbv Signed-off-by: Qiang Zhao <[email protected]>

drivers: dsa_nxp_imx_netc: add DSA Qbv support

f6f144f

Add DSA Qbv support, add set_config/get_config to set and get Qbv configuration. support enable/disable, set/get times, set/get list length and set/get gate control list. Signed-off-by: Qiang Zhao <[email protected]>

ZhaoQiang-b45475 force-pushed the support-qbv branch from 3bafe36 to b0d5430 Compare October 9, 2025 06:59

zephyrbot requested a review from jukkar October 9, 2025 07:01

ZhaoQiang-b45475 force-pushed the support-qbv branch from b0d5430 to 10919db Compare October 9, 2025 07:29

ZhaoQiang-b45475 added 2 commits October 9, 2025 13:22

net: shell: Add Qbv shell

6cb1c21

Added Qbv shell subcommand to net command. Supported enable, set_config, set_time and get_info functions. Signed-off-by: Qiang Zhao <[email protected]>

drivers: dsa_nxp_imx_netc: add Qbv capability

0686776

add Qbv capability for dsa_nxp_imx_netc Signed-off-by: Qiang Zhao <[email protected]>

ZhaoQiang-b45475 force-pushed the support-qbv branch from 10919db to 0686776 Compare October 9, 2025 07:52

JiafeiPan reviewed Oct 9, 2025

View reviewed changes

Add Qbv support, Qbv is Enhancements for Scheduled Traffic (EST) #96124

Are you sure you want to change the base?

Add Qbv support, Qbv is Enhancements for Scheduled Traffic (EST) #96124

Conversation

ZhaoQiang-b45475 commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yangbolu1991 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nashif commented Sep 25, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 9, 2025

Quality Gate passed

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ZhaoQiang-b45475 commented Sep 17, 2025 •

edited

Loading