Bluetooth: Controller: Add support for nRF54L15DK debug pins #96243
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for GPIO debug pins for the nRF54L15DK development kit, enabling Bluetooth controller debugging functionality on this new board. This extends the existing debug pin infrastructure to support a new Nordic hardware platform.
- Adds debug pin configuration for nRF54L15DK board in the debug header file
- Updates Kconfig to enable debug pins option for the new board
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/debug.h | Adds nRF54L15DK debug pin definitions and reorganizes board conditionals |
| subsys/bluetooth/controller/Kconfig.ll_sw_split | Adds nRF54L15DK to the list of supported boards for debug pins feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zephyrbot
requested review from
Tronil,
carlescufi,
erbr-ot,
ppryga,
thoh-ot and
wopu-ot
|
@diggit FYI. An old commit I had lying around, not adding DT support, but extension similar to earlier hard coded way of using GPIO debug pins. Contributions to convert to use of DT is welcome from the community. |
cvinayak
force-pushed
the
github_nrf54l15dk_bt_ctlr_debug_pins
branch
from
951e841 to
17e3214
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| #if defined(CONFIG_BT_CTLR_DEBUG_PINS) || \ | ||
| defined(CONFIG_BT_CTLR_DEBUG_PINS_CPUAPP) | ||
| #if defined(CONFIG_BOARD_NRF5340DK) | ||
| #if defined(CONFIG_BOARD_NRF54L15DK_NRF54L15_CPUAPP) |
There was a problem hiding this comment.
The original condition CONFIG_BOARD_NRF5340DK has been replaced, but the updated condition should maintain backward compatibility. Consider using #elif instead of replacing the original condition to ensure existing NRF5340DK configurations continue to work.
Copilot uses AI. Check for mistakes.
| #define DEBUG_PIN7 BIT(11) | ||
| #define DEBUG_PIN8 BIT(12) | ||
| #define DEBUG_PIN9 BIT(13) | ||
| #elif defined(CONFIG_BOARD_NRF5340DK_NRF5340_CPUAPP) || \ |
There was a problem hiding this comment.
The original CONFIG_BOARD_NRF5340DK condition has been expanded to three specific variants, but this may break compatibility if the original generic condition was used elsewhere. Verify that all NRF5340DK board configurations are properly covered by these three specific variants.
| #elif defined(CONFIG_BOARD_NRF5340DK_NRF5340_CPUAPP) || \ | |
| #elif defined(CONFIG_BOARD_NRF5340DK) || \ | |
| defined(CONFIG_BOARD_NRF5340DK_NRF5340_CPUAPP) || \ |
Copilot uses AI. Check for mistakes.
Add support for GPIO debug pins for nRF54L15DK. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
removed request for
Tronil,
carlescufi,
erbr-ot,
ppryga,
thoh-ot and
wopu-ot
cvinayak
dismissed
Thalley’s stale review
pin toggles are not working... dismissing this review,
cvinayak
force-pushed
the
github_nrf54l15dk_bt_ctlr_debug_pins
branch
from
17e3214 to
9c9087c
Compare
Add support for GPIO debug pins for nRF54L15DK. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_nrf54l15dk_bt_ctlr_debug_pins
branch
from
9c9087c to
33bd0ef
Compare
|
3 participants
Add support for GPIO debug pins for nRF54L15DK.
Relates to #93199.