BOARD: Add Ethernet support to frdm imx93 #96280
Conversation
Test PHY driver using zperf: west build -p always -b frdm_imx93/mimx9352/a55 samples/net/zperf/ Signed-off-by: Hongbo Wang <[email protected]>
PHY chip YT8521, the driver is: drivers/ethernet/phy/phy_motorcomm_yt8521.c Signed-off-by: Hongbo Wang <[email protected]>
CkovMk
force-pushed
the
pr/frdm-imx93-ethernet
branch
from
fcb69b4 to
631a8b0
Compare
zephyrbot
requested review from
ClaCodes,
DerekSnell,
EmilioCBen,
butok,
decsny,
dleach02,
lmajewski,
maass-hamburg,
mbolivar,
mmahadevan108,
pdgendt and
rruuaanng
|
Why can't the generic |
|
@maass-hamburg It may because YT8521 has device specific regs other than common MII regs. |
| /* set default reg space */ | ||
| mc_ytphy_write_ext(dev, YT8521_REG_SPACE_SELECT_REG, YT8521_RSSR_UTP_SPACE); | ||
|
|
||
| mc_ytphy_modify_ext(dev, YTPHY_SYNCE_CFG_REG, YT8521_SCR_SYNCE_ENABLE, 0); | ||
|
|
||
| ret = mc_ytphy_get_features(dev); | ||
| if (ret) { | ||
| return -EIO; | ||
| } | ||
|
|
||
| /* Reset PHY */ | ||
| ret = mc_ytphy_soft_reset(dev); | ||
| if (ret) { | ||
| return -EIO; | ||
| } | ||
|
|
||
| /* Enable clock delay */ | ||
| mc_ytphy_cfg_clock_delay(dev); | ||
|
|
||
| mc_ytphy_resume(dev); |
There was a problem hiding this comment.
it seems like these are the differences, check if these are needed, also the things that are set in them like the rx/tx rgmii delay isboard specific and should not be hardcoded and instead be props from the dt.
|
Added rx and tx delay sel dt props. Separate commit is created for easier review. Will squash it before merge. |
- Moves binding to phy subdir - Add rx and tx delay sel - Format code - Update frdm-imx93 dts accordingly Signed-off-by: Chekhov Ma <[email protected]>
CkovMk
force-pushed
the
pr/frdm-imx93-ethernet
branch
from
96eb915 to
c652c1a
Compare
|
|
The driver needs to be adapted to recent Zephyr version. Convert to draft. |
|
Close this one as a new PR is created for this: #97535 |
5 participants
Add YT8521 PHY driver and enable it on FRDM-IMX93