driver: sensor: Add Omron 2SMPB-02E digital barometric pressure sensor #96284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
JarmouniA,
MaureenHelm,
asemjonovs,
avisconti,
decsny,
jeppenodgaard,
kartben,
mbolivar,
nashif,
rruuaanng,
teburd,
tristan-google,
ubieda and
yperess
clementlgl
force-pushed
the
drivers/2smp02e
branch
3 times, most recently
from
7cc7a3b to
7398769
Compare
decsny
reviewed
Sep 19, 2025
| oki Oki Electric Industry Co., Ltd. | ||
| olimex OLIMEX Ltd. | ||
| olpc One Laptop Per Child | ||
| omron OMRON Corporation |
There was a problem hiding this comment.
@nashif please help review vendor prefix
ubieda
reviewed
Sep 25, 2025
samples/sensor/2smpb_02e/src/main.c
Outdated
There was a problem hiding this comment.
We'd rather have this sensor work with a generic sensor sample than having one sample per sensor, as it wouldn't scale.
I suggest looking at other tph-related samples.
There was a problem hiding this comment.
Okay, I've removed the sample.
clementlgl
force-pushed
the
drivers/2smp02e
branch
from
9d1eda4 to
63948a2
Compare
clementlgl
force-pushed
the
drivers/2smp02e
branch
2 times, most recently
from
27df2a8 to
f20fa0f
Compare
MaureenHelm
requested changes
Oct 20, 2025
Comment on lines
+17
to
+43
| #define COEFFICIENT_A1_A -6.3E-03 | ||
| #define COEFFICIENT_A1_S 4.3E-04 | ||
| #define COEFFICIENT_A2_A -1.9E-11 | ||
| #define COEFFICIENT_A2_S 1.2E-10 | ||
| #define COEFFICIENT_BT1_A 1.0E-01 | ||
| #define COEFFICIENT_BT1_S 9.1E-02 | ||
| #define COEFFICIENT_BT2_A 1.2E-08 | ||
| #define COEFFICIENT_BT2_S 1.2E-06 | ||
| #define COEFFICIENT_BP1_A 3.3E-02 | ||
| #define COEFFICIENT_BP1_S 1.9E-02 | ||
| #define COEFFICIENT_B11_A 2.1E-07 | ||
| #define COEFFICIENT_B11_S 1.4E-07 | ||
| #define COEFFICIENT_BP2_A -6.3E-10 | ||
| #define COEFFICIENT_BP2_S 3.5E-10 | ||
| #define COEFFICIENT_B12_A 2.9E-13 | ||
| #define COEFFICIENT_B12_S 7.6E-13 | ||
| #define COEFFICIENT_B21_A 2.1E-15 | ||
| #define COEFFICIENT_B21_S 1.2E-14 | ||
| #define COEFFICIENT_BP3_A 1.3E-16 | ||
| #define COEFFICIENT_BP3_S 7.9E-17 |
There was a problem hiding this comment.
Add a comment to document where these coefficients come from
Comment on lines
107
to
111
| static int o2smpb_02e_attr_set(const struct device *dev, enum sensor_channel chan, | ||
| enum sensor_attribute attr, const struct sensor_value *val) | ||
| { | ||
| return 0; | ||
| } |
Comment on lines
157
to
158
| val->val1 = (int32_t)temp; | ||
| val->val2 = (int32_t)((temp - val->val1) * 1000000); |
There was a problem hiding this comment.
Use sensor_value_from_float
Comment on lines
172
to
173
| val->val1 = (int32_t)press; | ||
| val->val2 = (int32_t)((press - val->val1) * 1000000); |
There was a problem hiding this comment.
Use sensor_value_from_float
| }; | ||
|
|
||
| #define O2SMPB_02E_INIT(n) \ | ||
| static struct o2smpb_02e_config o2smpb_02e_config_##n = { \ |
| .i2c = I2C_DT_SPEC_INST_GET(n), \ | ||
| }; \ | ||
| static struct o2smpb_02e_data o2smpb_02e_data_##n; \ | ||
| DEVICE_DT_INST_DEFINE(n, o2smpb_02e_init, NULL, &o2smpb_02e_data_##n, \ |
There was a problem hiding this comment.
Use SENSOR_DEVICE_DT_DEFINE
Comment on lines
10
to
19
| #define O2SMPB_02_REG_TEMP_TXD0 0xFC | ||
| #define O2SMPB_02_REG_TEMP_TXD1 0xFB | ||
| #define O2SMPB_02_REG_TEMP_TXD2 0xFA | ||
| #define O2SMPB_02_REG_PRESS_TXD0 0xF9 | ||
| #define O2SMPB_02_REG_PRESS_TXD1 0xF8 | ||
| #define O2SMPB_02_REG_PRESS_TXD2 0xF7 | ||
| #define O2SMPB_02_REG_RESET 0xE0 | ||
| #define O2SMPB_02_REG_CTRL_MEAS 0xF4 | ||
| #define O2SMPB_02_REG_CHIP_ID 0xD1 | ||
| #define O2SMPB_02_REG_COE_b00_1 0xA0 |
There was a problem hiding this comment.
This isn't really enough to justify having a separate private include. Move the defines to the .c file
| compatible: "omron,2smpb-02e" | ||
|
|
||
| include: [sensor-device.yaml] |
There was a problem hiding this comment.
Suggested change
| include: [sensor-device.yaml] | |
| include: [sensor-device.yaml, i2c-device.yaml] |
clementlgl
force-pushed
the
drivers/2smp02e
branch
from
f20fa0f to
6ffe42d
Compare
Support for the OMRON 2SMPB_02E digital barometric pressure sensor. Signed-off-by: Clément Laigle <[email protected]>
Co-authored-by: Luis Ubieda <[email protected]> Signed-off-by: Clément Laigle <[email protected]>
clementlgl
force-pushed
the
drivers/2smp02e
branch
from
6ffe42d to
929548e
Compare
|
MaureenHelm
approved these changes
Oct 21, 2025
ubieda
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Omron 2SMPB-02E digital barometric pressure sensor, including the driver and a sample application.
Omron 2SMPB-02E sensor driver integration:
drivers/sensor/omron/2smpb_02e/, including the main driver code (2smpb_02e.c), header (2smpb_02e.h), Kconfig, and CMakeLists.txt.Device tree and vendor bindings:
omron,2smpb-02e.yaml) and registered theomronvendor prefix (vendor-prefixes.txt).Sample application and documentation: