Skip to content

Conversation

ck-telecom
Copy link
Contributor

add sf32lb52x uart interrupt support

@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch 3 times, most recently from 9eda50d to eb0d82c Compare September 20, 2025 04:09
@ck-telecom ck-telecom marked this pull request as ready for review September 20, 2025 04:19
@zephyrbot zephyrbot added platform: SF32LB area: UART Universal Asynchronous Receiver-Transmitter labels Sep 20, 2025
@ck-telecom ck-telecom marked this pull request as draft September 20, 2025 06:00
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from eb0d82c to a6d3b18 Compare September 20, 2025 06:08
@ck-telecom ck-telecom marked this pull request as ready for review September 20, 2025 06:08
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from a6d3b18 to ab952c0 Compare September 20, 2025 06:14
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from ab952c0 to 04c7444 Compare September 21, 2025 13:15
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the IRQ flags are not being handled properly

@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from 04c7444 to c6b3a82 Compare September 21, 2025 15:18
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from c6b3a82 to cf6441a Compare September 22, 2025 14:38
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from cf6441a to 5b3754a Compare September 25, 2025 02:21
@ck-telecom
Copy link
Contributor Author

Run export ZEPHYR_BASE=${PWD}
Traceback (most recent call last):
  File "/home/runner/work/zephyr/zephyr/zephyr/./scripts/ci/test_plan.py", line 38, in <module>
    import list_boards
  File "/home/runner/work/zephyr/zephyr/zephyr/scripts/list_boards.py", line 14, in <module>
    import jsonschema
ModuleNotFoundError: No module named 'jsonschema'

this seems need install python jsonschema module

@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch 2 times, most recently from 271f296 to 9815b36 Compare September 26, 2025 07:50
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch 2 times, most recently from f60f9a6 to 63d41c6 Compare September 28, 2025 04:32
gmarull
gmarull previously approved these changes Sep 29, 2025
@gmarull gmarull requested a review from fabiobaltieri October 3, 2025 12:19
@kartben kartben requested a review from Copilot October 8, 2025 08:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds interrupt-driven UART support to the SF32LB serial driver. The changes enable asynchronous UART operations using interrupts instead of polling, which improves performance and reduces CPU usage.

  • Implements interrupt-driven UART functionality for SF32LB52x devices
  • Adds interrupt service routine and callback management
  • Includes error handling and status checking functions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
drivers/serial/uart_sf32lb.c Adds interrupt support infrastructure, ISR, FIFO operations, and interrupt control functions
drivers/serial/Kconfig.sf32lb Enables interrupt support capability in the driver configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch 3 times, most recently from c6552c7 to 90cee9c Compare October 9, 2025 15:32
@ck-telecom ck-telecom requested review from gmarull and kartben October 10, 2025 06:25
@gmarull gmarull requested a review from Copilot October 10, 2025 09:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gmarull
Copy link
Member

gmarull commented Oct 10, 2025

please provide some proof this branch works as expected.

@ck-telecom
Copy link
Contributor Author

ck-telecom commented Oct 10, 2025

please provide some proof this branch works as expected.

west build -p auto -b sf32lb52_devkit_lcd samples/drivers/uart/echo_bot/
west flash --runner=sftool --port <your port>

sifli trace tool seems bugs when input first word, so I am using PuTTY works well with COM5, buad rate 1000000

SFBL
    *** Booting Zephyr OS build v4.2.0-5356-g90cee9c36a53 ***
Hello! I'm your echo bot.
Tell me something and press enter:
h
Echo: h
hello
Echo: hello
123456799999999999999999999999999999999999999999
Echo: 1234567999999999999999999999999

add sf32lb52x uart interrupt support

Signed-off-by: Qingsong Gou <[email protected]>
@ck-telecom ck-telecom force-pushed the sf32lb_uart_interrupt branch from 90cee9c to 3cdfaa8 Compare October 13, 2025 15:23
Copy link

@gmarull gmarull requested a review from Copilot October 13, 2025 20:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jhedberg jhedberg merged commit ee9843c into zephyrproject-rtos:main Oct 14, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: UART Universal Asynchronous Receiver-Transmitter platform: SF32LB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants