drivers: input: add ft6146 driver #96330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faxe1008
reviewed
Sep 21, 2025
faxe1008
reviewed
Sep 21, 2025
faxe1008
reviewed
Sep 21, 2025
ck-telecom
force-pushed
the
ft6146
branch
6 times, most recently
from
870fa56 to
a41e843
Compare
ck-telecom
force-pushed
the
ft6146
branch
4 times, most recently
from
d3e4ab3 to
c8a9983
Compare
|
@ck-telecom hey feel free to undraft when you want another round on review, meanwhile in case you missed it check the sonarqubecloud comment as well, there' some valid stuff in there. |
faxe1008
reviewed
Oct 4, 2025
| } | ||
| chip_id |= (tmp << 8); | ||
|
|
||
| ret = i2c_reg_read_byte_dt(&config->i2c, FT6146_READ_ID_L, &tmp); |
There was a problem hiding this comment.
Is it possible to have this in one operation?
add initial driver for ft6146 Signed-off-by: Qingsong Gou <[email protected]>
|
faxe1008
approved these changes
Oct 9, 2025
faxe1008
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add initial driver for ft6146