Skip to content

Enable nxp MICFIL driver and Dialog DA7212 driver #96367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Enable nxp MICFIL driver and Dialog DA7212 driver #96367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
611f84a
dts: bindings: add dialog vendor prefix
ZhaoxiangJin Sep 29, 2025
3432318
drivers: audio: Add dialog7212 driver
ZhaoxiangJin Sep 29, 2025
6f15a7f
boards: frdm_mcxn236: Enable da7212 on frdm_mcxn236
ZhaoxiangJin Sep 29, 2025
d7fc5b1
samples: i2s_codec: Refine sample for samll RAM platforms
ZhaoxiangJin Sep 29, 2025
ffa63a5
samples: i2s_codec: enable i2s_codec samples for frdm_mcxn236
ZhaoxiangJin Sep 29, 2025
af1fa22
audio: dmic: Format dmic.h
ZhaoxiangJin Sep 29, 2025
e1b8489
drivers: audio: Add NXP MICFIL driver
ZhaoxiangJin Sep 29, 2025
a2a730b
drivers: mcux_syscon: enable MICFIL clock control
ZhaoxiangJin Sep 29, 2025
d5e9f21
board: frdm_mcxn236: Enable MICFIL on frdm_mcxn236
ZhaoxiangJin Sep 29, 2025
2c1449a
samples: i2s_codec: Enable nxp micfil test
ZhaoxiangJin Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions boards/nxp/frdm_mcxn236/board.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2024 NXP
* Copyright 2024-2025 NXP
* SPDX-License-Identifier: Apache-2.0
*/
#include <zephyr/init.h>
Expand Down Expand Up @@ -103,20 +103,23 @@ void board_early_init_hook(void)

CLOCK_SetupExtClocking(BOARD_XTAL0_CLK_HZ);

#if DT_NODE_HAS_STATUS_OKAY(DT_NODELABEL(sai0)) || DT_NODE_HAS_STATUS_OKAY(DT_NODELABEL(sai1))
#if DT_NODE_HAS_STATUS_OKAY(DT_NODELABEL(sai0)) || \
DT_NODE_HAS_STATUS_OKAY(DT_NODELABEL(sai1)) || \
DT_NODE_HAS_STATUS_OKAY(DT_NODELABEL(micfil))
/* < Set up PLL1 */
const pll_setup_t pll1_Setup = {
.pllctrl = SCG_SPLLCTRL_SOURCE(1U) | SCG_SPLLCTRL_SELI(3U) |
SCG_SPLLCTRL_SELP(1U),
.pllndiv = SCG_SPLLNDIV_NDIV(25U),
.pllpdiv = SCG_SPLLPDIV_PDIV(10U),
.pllmdiv = SCG_SPLLMDIV_MDIV(256U),
.pllRate = 24576000U};
.pllRate = 24576000U
};

/* Configure PLL1 to the desired values */
CLOCK_SetPLL1Freq(&pll1_Setup);
/* Set PLL1 CLK0 divider to value 1 */
CLOCK_SetClkDiv(kCLOCK_DivPLL1Clk0, 1U);
/* Set PLL1 CLK0 divider to value 2, then the clock is 12288000Hz. */
CLOCK_SetClkDiv(kCLOCK_DivPLL1Clk0, 2U);
#endif

#if DT_NODE_HAS_STATUS_OKAY(DT_NODELABEL(flexcomm0))
Expand Down Expand Up @@ -160,6 +163,7 @@ void board_early_init_hook(void)

#if DT_NODE_HAS_STATUS_OKAY(DT_NODELABEL(gpio0))
CLOCK_EnableClock(kCLOCK_Gpio0);
CLOCK_EnableClock(kCLOCK_Port0);
#endif

#if DT_NODE_HAS_STATUS_OKAY(DT_NODELABEL(gpio1))
Expand Down Expand Up @@ -339,6 +343,15 @@ void board_early_init_hook(void)
CLOCK_EnableClock(kCLOCK_Sai1);
#endif

#if DT_NODE_HAS_STATUS(DT_NODELABEL(micfil), okay)
CLOCK_SetClkDiv(kCLOCK_DivMicfilFClk, 1U);
CLOCK_AttachClk(kPLL1_CLK0_to_MICFILF);
CLOCK_EnableClock(kCLOCK_Micfil);

PORT0->PCR[16] = 0x00001900;
PORT0->PCR[17] = 0x00001900;
#endif

/* Set SystemCoreClock variable. */
SystemCoreClock = CLOCK_INIT_CORE_CLOCK;
}
29 changes: 26 additions & 3 deletions boards/nxp/frdm_mcxn236/frdm_mcxn236-pinctrl.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2024 NXP
* Copyright 2024-2025 NXP
* SPDX-License-Identifier: Apache-2.0
*/

Expand All @@ -8,8 +8,8 @@
&pinctrl {
pinmux_flexcomm0_lpuart: pinmux_flexcomm0_lpuart {
group0 {
pinmux = <FC0_P0_PIO0_16>,
<FC0_P1_PIO0_17>;
pinmux = <FC0_P2_PIO0_6>,
<FC0_P3_PIO0_7>;
slew-rate = "fast";
drive-strength = "low";
input-enable;
Expand Down Expand Up @@ -227,10 +227,33 @@
<SAI1_TXD0_PIO2_8>,
<SAI1_RX_FS_PIO1_7>,
<SAI1_RX_BCLK_PIO3_18>,
<SAI1_MCLK_PIO3_6>,
<SAI1_RXD0_PIO2_9>;
drive-strength = "high";
slew-rate = "fast";
input-enable;
};
};

pinmux_flexcomm2_i2c: pinmux_flexcomm2_i2c {
group0 {
pinmux = <FC2_P0_PIO4_0>,
<FC2_P1_PIO4_1>;
slew-rate = "fast";
drive-strength = "low";
input-enable;
bias-pull-up;
drive-open-drain;
};
};

pinmux_micfil: pinmux_micfil {
group0 {
pinmux = <PDM0_CLK_PIO0_16>,
<PDM0_DATA0_PIO0_17>;
drive-strength = "high";
slew-rate = "fast";
input-enable;
};
};
};
19 changes: 19 additions & 0 deletions boards/nxp/frdm_mcxn236/frdm_mcxn236.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,19 @@

&flexcomm2_lpi2c2 {
status = "okay";
pinctrl-0 = <&pinmux_flexcomm2_i2c>;
pinctrl-names = "default";
clock-frequency = <I2C_BITRATE_STANDARD>;
#address-cells = <1>;
#size-cells = <0>;

audio_codec: da7212@1a {
compatible = "dialog,da7212";
reg = <0x1a>;
clocks = <&syscon MCUX_SAI1_CLK>;
clock-source = "MCLK";
clock-names = "mclk";
};
};

&flexcomm3 {
Expand Down Expand Up @@ -427,3 +440,9 @@ dvp_20pin_interface: &video_sdma {};
pinctrl-0 = <&pinmux_sai1>;
pinctrl-names = "default";
};

&micfil {
status = "okay";
pinctrl-0 = <&pinmux_micfil>;
pinctrl-names = "default";
};
2 changes: 2 additions & 0 deletions drivers/audio/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,5 @@ zephyr_library_sources_ifdef(CONFIG_AUDIO_CODEC_CS43L22 cs43l22.c)
zephyr_library_sources_ifdef(CONFIG_AUDIO_CODEC_PCM1681 pcm1681.c)
zephyr_library_sources_ifdef(CONFIG_AUDIO_CODEC_MAX98091 max98091.c)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the reference manual so reviewers can analyze the hardware IP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it when i back to the office, but i'd like to know where the link should be added? I noticed that you made a comment in the CMakeLists file, so do I need to put link in the CMakeLists file? This seems rather strange.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link should be added in the commit message.

Also, this PR is a mix of everything adding a codec, adding a dmic driver, enhancements to samples, whitespace fixes to DMIC.

This is a nightmare to review. Let's pause a bit and organize everything in a more logical way so that we can have good code quality and have meaningful reviews.

Let's split this into multiple PRs like this:

PR1: Add support for Dialog7212 codec driver

This will include following patches:

ffa63a5 samples: i2s_codec: enable i2s_codec samples for frdm_mcxn236
6f15a7f boards: frdm_mcxn236: Enable da7212 on frdm_mcxn236
3432318 drivers: audio: Add dialog7212 driver
611f84a dts: bindings: add dialog vendor prefix

PR2: Small enhancements to audio
d7fc5b1 samples: i2s_codec: Refine sample for samll RAM platforms
af1fa22 audio: dmic: Format dmic.h

PR3: Add NXP DMIC MICFIL support
1449a5ed4 samples: i2s_codec: Enable nxp micfil test
d5e9f21 board: frdm_mcxn236: Enable MICFIL on frdm_mcxn236
a2a730b drivers: mcux_syscon: enable MICFIL clock control
e1b8489 drivers: audio: Add NXP MICFIL driver

This 3 PRs cand be sent separately are independent and can be reviewed in parallel. We go merge PR2 very fast.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to be careful of is the "refine sample for small RAM platforms".

It is unclear to me which set of enablement needed this fix. If it was needed for the da7212 enablement then put it before that set of commits. If needed for the MICFIL support then it is in the right place based on the recommendation.

The high-level guidance here is that each commit needs to stand on its own and be bisectable. There should be a logical grouping of commits. And don't overload a PR with a bunch of significant enablement because of the challenge it puts on the reviewers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"refine sample for small RAM platforms" should placed before i2s_codec example enablement for DA7212 and MICFIL, that is before ffa63a5 and 2c1449a.

From a technical/logical perspective, the commit sequence in this PR is well-structured and bisectable:

  1. Enable DA7212 driver
  2. Refine i2s_codec example for DA7212 and MICFIL test
  3. Enable DA7212 test
  4. Format dmic.h
  5. Enable MICFIL driver base DMIC device driver model
  6. Enable MICFIL test

However, I recognize my oversight regarding reviewer burden. I will split this PR, please move your comments to new PRs

zephyr_library_sources_ifdef(CONFIG_AUDIO_DMIC_AMBIQ_PDM dmic_ambiq_pdm.c)
zephyr_library_sources_ifdef(CONFIG_AUDIO_CODEC_DA7212 da7212.c)
zephyr_library_sources_ifdef(CONFIG_AUDIO_DMIC_NXP_MICFIL dmic_nxp_micfil.c)
2 changes: 2 additions & 0 deletions drivers/audio/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ source "drivers/audio/Kconfig.tlv320aic3110"
source "drivers/audio/Kconfig.tlv320dac"
source "drivers/audio/Kconfig.wm8904"
source "drivers/audio/Kconfig.wm8962"
source "drivers/audio/Kconfig.da7212"

endif # AUDIO_CODEC

Expand All @@ -67,6 +68,7 @@ source "drivers/audio/Kconfig.mpxxdtyy"
source "drivers/audio/Kconfig.dmic_pdm_nrfx"
source "drivers/audio/Kconfig.dmic_mcux"
source "drivers/audio/Kconfig.dmic_ambiq_pdm"
source "drivers/audio/Kconfig.dmic_nxp_micfil"

endif # AUDIO_DMIC

Expand Down
10 changes: 10 additions & 0 deletions drivers/audio/Kconfig.da7212
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Copyright 2025 NXP
# SPDX-License-Identifier: Apache-2.0

config AUDIO_CODEC_DA7212
bool "Dialog DA7212 codec support"
default y
select I2C
depends on DT_HAS_DIALOG_DA7212_ENABLED
help
Enable support for the Dialog DA7212 audio codec.
22 changes: 22 additions & 0 deletions drivers/audio/Kconfig.dmic_nxp_micfil
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Copyright 2025 NXP
#
# SPDX-License-Identifier: Apache-2.0

config AUDIO_DMIC_NXP_MICFIL
bool "NXP MICFIL driver"
default y
depends on DT_HAS_NXP_MICFIL_ENABLED
select HAS_MCUX
select CLOCK_CONTROL
help
Enable NXP MICFIL driver.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer everywhere as DMIC PDM to avoid confusion with MICFIL PDM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed the driver to micfil, please review

if AUDIO_DMIC_NXP_MICFIL

config DMIC_NXP_MICFIL_QUEUE_SIZE
int "Message queue depth"
default 4
help
Depth of the message queue used to pass filled buffers to the app.

endif # AUDIO_DMIC_NXP_MICFIL
Loading
Loading