Bluetooth: CAP: Add ep conn check in unicast audio start #96371
+487
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new function, bt_bap_ep_get_conn, which returns the ACL connection for the endpoint. This works because endpoints are specific to an ACL in BAP. The function returns a pointer with a new reference similar to the lookup functions from conn.h The conn pointer was not added to the bt_bap_ep_info struct, as doing so would be more likely to cause reference leaks if the caller did not care about the conn pointer when using bt_bap_ep_get_info. It can be added later if that is requested. Signed-off-by: Emil Gydesen <[email protected]>
Add entry for the new function bt_bap_ep_get_conn. Signed-off-by: Emil Gydesen <[email protected]>
Add steps in the BAP tests to verify the correctness of bt_bap_ep_get_conn. Signed-off-by: Emil Gydesen <[email protected]>
Add check in valid_unicast_audio_start_param to verify that the ep connection matches the member_conn. Signed-off-by: Emil Gydesen <[email protected]>
Add bt_bap_unicast_client_unregister_cb to unregister BAP unicast client callbacks. This is required for unittests to clean up between runs. Signed-off-by: Emil Gydesen <[email protected]>
Instead of declaring the endpoints in the unit tests, we not define them in the mock unicast client and use the discover function to get pointers. This allows for a proper implementation of bt_bap_unicast_client_has_ep as well as makes the tests more similar to a normal application. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
cap_ep_conn_check
branch
from
08dc01f to
80f9c25
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check in valid_unicast_audio_start_param to verify that the ep connection matches the member_conn.