scripts: west_commands: extend build.dir-fmt format args
#96421
+261
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
carlescufi,
kartben,
marc-hb,
mbolivar,
nashif,
pdgendt and
swinslow
thorsten-klein
force-pushed
the
extend-dir-fmt-format-args
branch
2 times, most recently
from
411e776 to
03d0ed0
Compare
marc-hb
reviewed
Sep 24, 2025
There was a problem hiding this comment.
Looking at all the os.cwd() (which should probably be Path.cwd()), I wonder about people using west outside the west workspace, thanks to the ZEPHYR_BASE variable. How is this going to work for them? Has dir-fmt ever worked for them? It's OK if it does not but then it should fail clearly and "gracefully".
Noob questions sorry.
thorsten-klein
force-pushed
the
extend-dir-fmt-format-args
branch
14 times, most recently
from
4a4bd90 to
1cfc21e
Compare
tejlmand
reviewed
Sep 26, 2025
thorsten-klein
force-pushed
the
extend-dir-fmt-format-args
branch
4 times, most recently
from
4fbdfa3 to
2b455ec
Compare
marc-hb
reviewed
Sep 26, 2025
build.dir-fmt format string arguments are extended. New format args are 'west_topdir' (absolute path to the west workspace directory) and 'source_dir_workspace' (relative path of the source directory to west_topdir). Signed-off-by: Thorsten Klein <[email protected]>
thorsten-klein
force-pushed
the
extend-dir-fmt-format-args
branch
from
2b455ec to
f612541
Compare
|
|
Is there anything else I should provide or address to get this feature merged? 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.dir-fmtformat string arguments are extended.New supported format args are:
{west_topdir}which is the absolute path to the west workspace directory (west topdir). This is helpful for users when they want to place all build folders under a fix path within the west workspace.{source_dir_workspace}which is the relative path of the source directory to the west workspace (west topdir). If the source directory is outside of the west workspace,{source_dir_workspace}will be relative to the filesystem root.{source_dir_workspace}is helpful to keep builds in separate folders under a specific subfolder. Since the path is relative to west topdir , it does not matter in which working directory thewest buildcommand was called.Background:
{source_dir}cannot be used currently since it is relative to the current working directory and it might therefore be a relative path starting with../.{source_dir_ws}will never start with../.E.g. users can now use following
dir-fmtin order to store builds under a fix path<west_workspace>/build/: