Skip to content

drivers: auxdisplay: Add TM1637 7-segment display driver #96510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

drivers: auxdisplay: Add TM1637 7-segment display driver #96510

wants to merge 3 commits into from
+468 −0

Conversation

heronet
Copy link
Contributor

@heronet heronet commented Sep 24, 2025 •
edited
Loading

Add a new auxdisplay driver for TM1637 7-segment LED displays. The driver supports:

  • 4-digit 7-segment display output
  • Decimal point positioning
  • Brightness control (0-7 levels)
  • Display on/off control
  • Alphabet character support (A-Z, a-z) and digits (0-9)
  • Basic cursor positioning

The driver implements the standard AUXDISPLAY API

@zephyrbot zephyrbot added area: LED Label to identify LED subsystem area: Devicetree area: Samples Samples labels Sep 24, 2025
@heronet heronet force-pushed the add-tm1637-driver branch 2 times, most recently from a67e10d to 8702ccd Compare September 24, 2025 21:04
kartben
kartben previously requested changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't be requiring a custom, device-specific, API for this - please implement this as an auxdisplay driver. Custom sample will likely also go away in the process

Thanks!

@zephyrbot zephyrbot requested review from thedjnK and xingrz September 25, 2025 08:28
@heronet
Copy link
Contributor Author

heronet commented Sep 25, 2025

you shouldn't be requiring a custom, device-specific, API for this - please implement this as an auxdisplay driver. Custom sample will likely also go away in the process

Thanks!

Got it. I reimplemented it for the auxdisplay subsystem. Thanks

@heronet heronet requested a review from kartben September 25, 2025 10:24
@kartben kartben removed the area: LED Label to identify LED subsystem label Sep 26, 2025
@kartben kartben closed this Sep 26, 2025
@kartben kartben reopened this Sep 26, 2025
@thedjnK
Copy link
Contributor

thedjnK commented Sep 30, 2025

Also there is a lot of changing of GPIO mode from input to output, would it be better to just configure it at start-up as output then to input and output again in that function, and optionally in on/off functions?

@heronet
Copy link
Contributor Author

heronet commented Sep 30, 2025 •
edited
Loading

Also there is a lot of changing of GPIO mode from input to output, would it be better to just configure it at start-up as output then to input and output again in that function, and optionally in on/off functions?

Yes. That is what I should have done in the first place

Edit: Well the CLK can be removed but the DIO pin does need to be reconfigured to OUTPUT before start/stop conditions because it's left in INPUT mode after reading the ACK signal in tm1637_send_byte()

@heronet heronet requested a review from thedjnK September 30, 2025 21:06
simonguinot
simonguinot requested changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@simonguinot simonguinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @heronet,

Thanks for this PR.

Please find my review below !

@kartben kartben dismissed their stale review October 1, 2025 12:30

my initial comment has been addressed

@heronet heronet force-pushed the add-tm1637-driver branch from 8bb9dc4 to 3ef56cb Compare October 1, 2025 15:32
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 1, 2025
@heronet heronet requested a review from simonguinot October 1, 2025 15:41
@heronet
Copy link
Contributor Author

heronet commented Oct 1, 2025

Hello @heronet,

Thanks for this PR.

Please find my review below !

Hi @simonguinot,
Thanks for reviewing it so thoroughly. I implemented your suggestions and I will be waiting for your review when you get the time.

@heronet
Copy link
Contributor Author

heronet commented Oct 5, 2025

Hi @thedjnK, @mbolivar, @kartben, @nashif, @xingrz, and other reviewers,

I wanted to check in on this PR for the TM1637 7-segment display driver. Please let me know if there are any remaining changes or feedback required to help move it forward. This is my first time sumbitting a driver so that would make sense.
Thank you for your time and reviews!

xingrz
xingrz requested changes Oct 6, 2025
View reviewed changes
@heronet
dts: bindings: auxdisplay: Add TM1637 binding
977af5e 
Add device tree binding for TitanMicro TM1637 7-segment LED
display controller. The TM1637 uses a GPIO bit-banging protocol
with clock and data pins.

Properties:
- clk-gpios: Clock GPIO pin
- dio-gpios: Data I/O GPIO pin
- bit-delay-us: Bit delay for GPIO protocol timing

Signed-off-by: Siratul Islam <[email protected]>
@heronet heronet force-pushed the add-tm1637-driver branch from 3ef56cb to b74ba5e Compare October 6, 2025 13:40
@heronet heronet requested a review from xingrz October 6, 2025 13:41
@heronet
Copy link
Contributor Author

heronet commented Oct 6, 2025

Hi @xingrz,
I believe I have addressed your review — could you please confirm or approve if all is okay?

xingrz
xingrz reviewed Oct 6, 2025
View reviewed changes
Copy link
Member

@xingrz xingrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Just a minor thought - it might be a bit clearer to define the segment codes using BIT(x) combinations instead of magic numbers. But it’s totally fine to keep it as is if you prefer.

@heronet
Copy link
Contributor Author

heronet commented Oct 6, 2025

Hi @xingrz,

Thanks for taking a look again! I kept them in hex since it follows the standard convention for 7-segment lookup tables (e.g., https://en.wikichip.org/wiki/seven-segment_display/representing_letters). The hex format is more compact and matches how most 7-segment drivers represent these patterns.

Happy to change to BIT() macros if you prefer though.

Thanks

@heronet heronet requested a review from xingrz October 6, 2025 15:24
xingrz
xingrz previously approved these changes Oct 6, 2025
View reviewed changes
mbolivar
mbolivar reviewed Oct 6, 2025
View reviewed changes
@heronet heronet requested a review from mbolivar October 6, 2025 20:52
heronet added 2 commits October 7, 2025 03:03
@heronet
drivers: auxdisplay: Add TM1637 7-segment display driver
88edce2 
Add a new auxdisplay driver for TM1637 7-segment LED displays.

The driver supports:
- 4-digit 7-segment display output
- Decimal point positioning
- Brightness control (0-7 levels)
- Display on/off control
- Alphabet character support (A-Z, a-z) and digits (0-9)
- Basic cursor positioning

The driver implements the standard AUXDISPLAY API

Signed-off-by: Siratul Islam <[email protected]>
@heronet
tests: drivers: auxdisplay: Add TM1637 build test
a877018 
Add build test coverage for the TM1637 auxdisplay driver.

Creates gpio_devices.overlay for GPIO-based auxdisplay devices
and adds corresponding test case to verify the driver builds
correctly on native_sim platforms.

Signed-off-by: Siratul Islam <[email protected]>
@heronet heronet force-pushed the add-tm1637-driver branch from b74ba5e to a877018 Compare October 6, 2025 21:04
@heronet heronet requested a review from xingrz October 6, 2025 21:25
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbolivar mbolivar mbolivar approved these changes

@xingrz xingrz xingrz approved these changes

@decsny decsny Awaiting requested review from decsny

@JarmouniA JarmouniA Awaiting requested review from JarmouniA

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

@Mani-Sadhasivam Mani-Sadhasivam Awaiting requested review from Mani-Sadhasivam

@nashif nashif Awaiting requested review from nashif

@rruuaanng rruuaanng Awaiting requested review from rruuaanng

@kartben kartben Awaiting requested review from kartben

@thedjnK thedjnK Awaiting requested review from thedjnK

@simonguinot simonguinot Awaiting requested review from simonguinot

Requested changes must be addressed to merge this pull request.

Assignees

@thedjnK thedjnK

Labels
area: Aux display area: Boards/SoCs area: Devicetree Bindings area: Devicetree area: Samples Samples area: Tests Issues related to a particular existing or missing test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@heronet @thedjnK @mbolivar @kartben @xingrz @simonguinot @Mani-Sadhasivam @zephyrbot