-
Notifications
You must be signed in to change notification settings - Fork 8k
drivers: display: Introduce st730x display controller #96524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2a17a40
to
f41a14d
Compare
Build failure unrelated to pr. |
rebased on main to try fix build failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Letting you decide what you wish to do for #96524 (comment) but otherwise LGTM!
Very sharp indeed! 😯
drivers/display/display_st730x.c
Outdated
|
||
if (!device_is_ready(config->mipi_dev)) { | ||
LOG_ERR("MIPI Device not ready!"); | ||
return -EINVAL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be -ENODEV
based on grep -R -A2 '!device_is_ready' drivers/
, but really I never know which errno to pick!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits, otherwise looks good, thanks!
@VynDragon You shoud provide an explanation when changing/removing PR assignee, will provide one for this instance. PR concerns display drivers mainly, Tests' change is minor & trivial, hence add Display collaborator as assignee. |
well usually nashif unassign themselves silently... |
I guess an assignee does not have to explain themselves when removing their assignment. |
@VynDragon - needs a rebase to fix merge conflicts. |
Introduces epaper-like high resolution st730x serie controllers. b&w only Signed-off-by: Camille BAUD <[email protected]>
Add tests for st730x display controllers. Signed-off-by: Camille BAUD <[email protected]>
|
Introduces ST730x series of display controllers.
These displays are epaper-like but with much higher refresh rate. They appear to have similar construction to epaper and lack a contrast control. Their readability is great until framerate is increased, then it drops massively at 51Hz, and looks fine up to 32Hz (the framerate is a specific setting).




(demonstrating loss of contrast at higher framerate)
Tested on shineworld/generic 4.2 inches st7306 and 2.9 inches st7305 B&W panels. This driver doesnt support color but it is a possible future addition as some models support many color and greyscale formats.