drivers: input: Add input driver support on RSK-RX130 #96559

quytranpzz · 2025-09-25T11:18:02Z

Add Input subsys support on Renesas RX CTSU HWIP

github-actions · 2025-09-25T11:19:10Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

drivers/input/input_renesas_rx_ctsu.c

samples/boards/renesas/ctsu_input/src/main.c

thenguyenyf

LGTM

KhiemNguyenT

Look good to me, too.

fabiobaltieri · 2025-10-09T04:52:40Z

drivers/input/input_renesas_rx_ctsu.c

+	}
+
+	if (data->work_phase == SCANNING) {
+		if (p_arg->event == CTSU_EVENT_SCAN_COMPLETE) {


swap the argument, unindent the normal case and return on this one

if (p_arg->event != CTSU_EVENT_SCAN_COMPLETE) { return; } k_work_submit(&data->data_process_work); You could probably also merge the two conditions? return if `data->work_phase == SCANNING && p_arg->event ~= CTSU_EVENT_SCAN_COMPLETE`

It's done, thank you

fabiobaltieri · 2025-10-09T04:52:57Z

drivers/input/input_renesas_rx_ctsu.c

+		CONTAINER_OF(work, struct renesas_rx_ctsu_data, data_process_work);
+	const struct device *dev = data->dev;
+	const struct renesas_rx_ctsu_config *config = dev->config;
+	fsp_err_t ret = FSP_SUCCESS;


drop the initializer, you literally set this in the next line

fabiobaltieri · 2025-10-09T04:53:39Z

drivers/input/input_renesas_rx_ctsu.c

+	int button_position = 0;
+
+	while (changed_buttons != 0) {
+		if (changed_buttons & 0x1) {


BIT(0) instead of 0x01? up to you, no strong feelings

yah, I have updated, thanks

fabiobaltieri · 2025-10-09T04:53:56Z

drivers/input/input_renesas_rx_ctsu.c

+			int index = config->button_position_index[button_position];
+
+			input_report_key(dev, config->buttons[index].event,
+					 data->curr_buttons_data & (1 << button_position), true,


BIT(button_position) instead of 1 << button_position

fabiobaltieri · 2025-10-09T04:54:41Z

drivers/input/input_renesas_rx_ctsu.c

+	}
+}
+
+void timer_callback(struct k_timer *timer)


thanks, I have updated

fabiobaltieri · 2025-10-09T04:59:10Z

samples/boards/renesas/ctsu_input/src/main.c

+	}
+}
+
+void button2_task(void)


fabiobaltieri · 2025-10-09T04:59:17Z

samples/boards/renesas/ctsu_input/src/main.c

+#endif /* CONFIG_INPUT_RENESAS_RX_QE_TOUCH_CFG */
+}
+
+void button1_task(void)


fabiobaltieri · 2025-10-09T04:59:52Z

samples/boards/renesas/ctsu_input/src/main.c

+#define DEBOUNCE_TIMES       3
+#define DEBOUNCE_INTERVAL_MS (500 / DEBOUNCE_TIMES)


unused? drop

thanks, dropped it

fabiobaltieri · 2025-10-09T05:02:32Z

samples/boards/renesas/ctsu_input/src/main.c

+			leds_on_off[(current_main_led + i) % 4] =
+				((led_state >> i) & 0x1) ? LED_ON : LED_OFF;


why not just have a

if (led_state & BIT(i)) { gpio_pin_set_dt(...) } else { gpio_pin_set_dt(...) }

current logic seems unnecessarily complicated, two cycles, the global variable...

Updated the code, thanks

fabiobaltieri · 2025-10-09T05:03:43Z

samples/boards/renesas/ctsu_input/src/qe_generated_files/qe_touch_define.h

+#define QE_TOUCH_DEFINE_H
+
+/* Macro definitions */
+#define QE_TOUCH_VERSION (0x0420)


drop the parenthesis from the literals here, they are only needed on expressions, no point adding them everywhere

dropped the parenthesis

fabiobaltieri · 2025-10-09T05:05:17Z

hey, few coding style things, sorry for the delay reviewing this, ooo at the moment

fabiobaltieri · 2025-10-13T10:03:43Z

drivers/input/input_renesas_rx_ctsu.c

+		k_sem_give(&data->tune_scan_end);
+	}
+
+	if (data->work_phase == SCANNING) {


can you swap this and make it an early return as well? May even do a single if with the one below

I updated this, could you please take a look?

fabiobaltieri · 2025-10-13T10:05:01Z

drivers/input/input_renesas_rx_ctsu.c

+#ifndef CONFIG_INPUT_RENESAS_RX_QE_TOUCH_CFG
+#define CTSU_HAL_CONFIG_DEFINE(idx)                                                                \
+	.ctsu_cfg =                                                                                \
+		{                                                                                  \


nit: bring this to the line above? that's the normal formatting, I usually let it go on macros because I know clang-format does not respect that but you have it right on the field below so I presume you are manually indenting, may as well

Actually, I did try moving it to the line above as in the field below, but clang-format automatically reformatted it to the current layout

Add support for Capatitive Touch Sensing Unit driver for RX MCUs Signed-off-by: Minh Tang <[email protected]>

Add support CTSU device tree node for Renesas RX130 Signed-off-by: Minh Tang <[email protected]>

Add Pinctrl, status okay for CTSU node on RSK-RX130 Signed-off-by: Minh Tang <[email protected]>

Add sample for CTSU input driver using QE config files on RSK-RX130-512KB Signed-off-by: Minh Tang <[email protected]>

sonarqubecloud · 2025-10-13T11:04:14Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fabiobaltieri · 2025-10-13T14:23:42Z

@quytranpzz hey, sorry this needs a rebase now

github-actions bot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Sep 25, 2025

quytranpzz force-pushed the rx_zephyr_support_ctsu branch 2 times, most recently from d4c5731 to 4dd7324 Compare September 26, 2025 06:40

quytranpzz marked this pull request as ready for review September 26, 2025 08:33

zephyrbot added area: RX platform: Renesas Renesas area: Input Input Subsystem and Drivers platform: Renesas RA Renesas Electronics Corporation, RA area: Samples Samples labels Sep 26, 2025

zephyrbot requested review from JarmouniA, KhiemNguyenT, andrzej-kaczmarek, blauret, duynguyenxa, fabiobaltieri, ioannis-karachalios, kartben, khoa-nguyen-18, nashif, soburi, thaoluonguw, thenguyenyf and ydamigos September 26, 2025 08:35

zephyrbot assigned fabiobaltieri Sep 26, 2025

thenguyenyf reviewed Oct 1, 2025

View reviewed changes

quytranpzz force-pushed the rx_zephyr_support_ctsu branch from 4dd7324 to 04a6047 Compare October 8, 2025 16:14

github-actions bot removed the manifest label Oct 8, 2025

github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Oct 8, 2025

quytranpzz requested a review from thenguyenyf October 8, 2025 16:15

zephyrbot added area: Boards/SoCs area: Devicetree Bindings labels Oct 8, 2025

quytranpzz force-pushed the rx_zephyr_support_ctsu branch from 04a6047 to 7fccb78 Compare October 8, 2025 16:23

thenguyenyf previously approved these changes Oct 9, 2025

View reviewed changes

KhiemNguyenT previously approved these changes Oct 9, 2025

View reviewed changes

KhiemNguyenT added this to the v4.3.0 milestone Oct 9, 2025

fabiobaltieri requested changes Oct 9, 2025

View reviewed changes

quytranpzz dismissed stale reviews from KhiemNguyenT and thenguyenyf via 013669e October 10, 2025 04:41

quytranpzz force-pushed the rx_zephyr_support_ctsu branch from 7fccb78 to 013669e Compare October 10, 2025 04:41

zephyrbot requested review from KhiemNguyenT and fabiobaltieri October 10, 2025 04:43

quytranpzz requested a review from thenguyenyf October 10, 2025 04:47

duynguyenxa added platform: Renesas RX Renesas Electronics Corp, RX and removed platform: Renesas RA Renesas Electronics Corporation, RA labels Oct 13, 2025

fabiobaltieri reviewed Oct 13, 2025

View reviewed changes

Minh Tang added 4 commits October 13, 2025 10:45

drivers: ctsu: Add support CTSU driver for RX MCUs

af48324

Add support for Capatitive Touch Sensing Unit driver for RX MCUs Signed-off-by: Minh Tang <[email protected]>

dts: rx: renesas: Add CTSU node for RX130

046912f

Add support CTSU device tree node for Renesas RX130 Signed-off-by: Minh Tang <[email protected]>

boards: renesas: Add support CTSU for RSK-RX130 board

966aba7

Add Pinctrl, status okay for CTSU node on RSK-RX130 Signed-off-by: Minh Tang <[email protected]>

samples: boards: renesas: Add sample for CTSU input driver

da088e5

Add sample for CTSU input driver using QE config files on RSK-RX130-512KB Signed-off-by: Minh Tang <[email protected]>

quytranpzz force-pushed the rx_zephyr_support_ctsu branch from 013669e to da088e5 Compare October 13, 2025 10:47

zephyrbot added the platform: Renesas RA Renesas Electronics Corporation, RA label Oct 13, 2025

zephyrbot requested a review from fabiobaltieri October 13, 2025 10:48

fabiobaltieri approved these changes Oct 13, 2025

View reviewed changes

thenguyenyf approved these changes Oct 13, 2025

View reviewed changes

		#define DEBOUNCE_TIMES 3
		#define DEBOUNCE_INTERVAL_MS (500 / DEBOUNCE_TIMES)

		leds_on_off[(current_main_led + i) % 4] =
		((led_state >> i) & 0x1) ? LED_ON : LED_OFF;

drivers: input: Add input driver support on RSK-RX130 #96559

Are you sure you want to change the base?

drivers: input: Add input driver support on RSK-RX130 #96559

Conversation

quytranpzz commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thenguyenyf left a comment

Choose a reason for hiding this comment

Uh oh!

KhiemNguyenT left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabiobaltieri commented Oct 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 13, 2025

Quality Gate passed

Uh oh!

fabiobaltieri commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Sep 25, 2025 •

edited

Loading