Skip to content

script: footprint: Improve C++ static variable reporting #96573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −11
Open

script: footprint: Improve C++ static variable reporting #96573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 27 additions & 11 deletions scripts/footprint/size_report
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ def do_address_range_matching(dwarfinfo, symbol_dict, processed):
offset_map[die.offset] = die

for die in cu_list[cu]['dies']:
if not die.tag == 'DW_TAG_subprogram':
if not (die.tag == 'DW_TAG_subprogram' or die.tag == 'DW_TAG_variable'):
continue

path = None
Expand Down Expand Up @@ -507,16 +507,32 @@ def do_address_range_matching(dwarfinfo, symbol_dict, processed):
if low is None:
continue

for ums in unmapped_symbols:
for one_sym in symbol_dict[ums]:
symbol = one_sym['symbol']
symaddr = symbol['st_value']

if symaddr not in mapped_addresses:
if low <= symaddr < high:
one_sym['mapped_files'].add(path)
mapped_addresses.add(symaddr)
newly_mapped_syms.add(ums)
# Case 1: Match for a function (using a range)
if die.tag == 'DW_TAG_subprogram':
for ums in unmapped_symbols:
for one_sym in symbol_dict[ums]:
symbol = one_sym['symbol']
symaddr = symbol['st_value']

if symaddr not in mapped_addresses:
if low <= symaddr < high:
one_sym['mapped_files'].add(path)
mapped_addresses.add(symaddr)
newly_mapped_syms.add(ums)

# Case 2: Match for a variable (using a single address)
elif die.tag == 'DW_TAG_variable':
for ums in unmapped_symbols:
for one_sym in symbol_dict[ums]:
symbol = one_sym['symbol']
symaddr = symbol['st_value']

if symaddr not in mapped_addresses:
# We expect the 'high' value to be 'low + 1' for a variable
if low == symaddr:
one_sym['mapped_files'].add(path)
mapped_addresses.add(symaddr)
newly_mapped_syms.add(ums)

mapped_symbols = mapped_symbols.union(newly_mapped_syms)
unmapped_symbols = unmapped_symbols.difference(newly_mapped_syms)
Expand Down
Loading