Bluetooth: BAP: Broadcast source: sonarcloud fixes #96648
+276
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
broadcast_source_sonar_fixes
branch
2 times, most recently
from
9c0e9d6 to
fd71104
Compare
zephyrbot
requested review from
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot and
sjanc
Move the subgroup parameter validation to its own function to reduce the size and complexity of valid_broadcast_source_param to make Sonarcube happy. Signed-off-by: Emil Gydesen <[email protected]>
Refactor the bt_bap_broadcast_source_reconfig function to be less complex by splitting the verification into multiple functions. Additionally, it also fixes a rare, but potential, issue where some subgroups were updated before a later subgroup would fail to be updated. Added can_merge_codec_cfg_data to verify correctness before we attempt to update any subgroups. This new check is also applied to bt_bap_broadcast_source_create. Signed-off-by: Emil Gydesen <[email protected]>
The broadcast_state variable was not used in bt_bap_broadcast_source_update_metadata to verify the state, but broadcast_source_get_state was instead called twice. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
broadcast_source_sonar_fixes
branch
from
fd71104 to
2cdc368
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues reported by sonarcloud w.r.t. complex functions and a missing read of a variable.