drivers: flash: Introduce BFLB flash driver.

[VynDragon]

Introduce flash driver for 1 bank of flash (all of them on bl60x and bl70x, half of them on bl61x)

Caveat: no bank2 support (feature of bl61x)
Not sure how to handle the flash naming and devices as they are either separate die flash or external flash but need the controller to work (and so be soc-nv-flash).

[github-actions]

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_bouffalolab	zephyrproject-rtos/hal_bouffalolab@9f2ab1b (main)	zephyrproject-rtos/hal_bouffalolab#5	zephyrproject-rtos/hal_bouffalolab#5/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

[josuah]

It looks like a half-hardware (automatic read/write flash commands) half-software (manual config flash commands) peripheral. First time I see this (I've obviously not seen a lot).

[VynDragon]

It looks like a half-hardware (automatic read/write flash commands) half-software (manual config flash commands) peripheral.

I think it's pretty common? RP2 memory peripheral has the same kind of things for both flash and PSRAM. It allows using any kind of flash and other more exotic (mram, psram, etc) stuffs

[VynDragon]

I think I got all of the review comments? Might try another push with clang-format

[josuah]

Here is another round of review, I hope I caught everything this time.

I've been marking the existing checks and a few more. May you fold the comments that do not need a fix.

[josuah]

I noticed I was not sure when function call errors should be ignored (some valid use-cases for that, i.e. do not break XIP for a temporary error) or not. So I marked them for you to tell, if that's ok.

I realize ESP-IDF has macros to automate if (ret) { return ret; }.

I think that's all though. It's a pretty large driver. A lot of code needed.

[VynDragon]

anyway fun fact time, it's the 7th biggest driver in the folder... And there is still a bunch of features to add 😭

[josuah]

I did not catch anything on this last round.
Thanks for all the effort!
Looking at other flash drivers, they are also very software-defined + it's HAL-free, so that's where the actual code is.
One more flash driver for Zephyr...

[VynDragon]

Added the flash test thing because it wasnt added.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[josuah]

This confirms that the CI hotfix for flash worked, in a way.

[VynDragon]

Not quite, this one never failed due the issue... because it had a flash driver