Add Bluetooth HCI driver for SiFli SF32LB chipsets. #96692

gangheivt · 2025-09-29T03:12:15Z

No description provided.

github-actions · 2025-09-29T03:12:59Z

Hello @gangheivt, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

gmarull

looks like this is missing a PR in HAL and a manifest update?

gangheivt · 2025-09-30T01:47:29Z

looks like this is missing a PR in HAL and a manifest update?
Please refer to this PR.
zephyrproject-rtos/hal_sifli#1
Thanks

gmarull · 2025-09-30T07:04:39Z

looks like this is missing a PR in HAL and a manifest update?
Please refer to this PR.
zephyrproject-rtos/hal_sifli#1
Thanks

Manifest needs to be updated accordingly

jhedberg · 2025-10-03T07:54:08Z

@gangheivt as requested in #96692 (comment) you need to add the appropriate reference in west.yml to your HAL PR as per https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules

Additionally, please do a rebase to get rid of the merge commits - those are not allowed in Zephyr pull requests.

github-actions · 2025-10-04T02:32:31Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_sifli	zephyrproject-rtos/hal_sifli@`7be4210` (`main`)	❌ Impostor SHA: zephyrproject-rtos/hal_sifli@`f457f7b`	zephyrproject-rtos/[email protected]

⛔ DNM label due to: 1 impostor SHA

Note: This message is automatically posted and updated by the Manifest GitHub Action.

gmarull

fix all compliance issues as well

dts/arm/sifli/sf32lb52x-ram012.dtsi

dts/arm/sifli/sf32lb52x.dtsi

dts/bindings/bluetooth/sifli,sf32lb-mailbox.yaml

dts/arm/sifli/sf32lb52x-ram012.dtsi

soc/sifli/sf32/sf32lb52x/soc.c

gmarull · 2025-10-06T08:03:30Z

drivers/bluetooth/hci/hci_sf32lb.c

+#ifndef CONFIG_SIFLI_LXT_DISABLE
+    /* Enable LXT32K */
+    HAL_PMU_EnableXTAL32();
+    if (HAL_PMU_LXTReady() != HAL_OK) {
+        HAL_ASSERT(0);
+    }
+    /* RTC/GTIME/LPTIME Using same low power clock source */
+    HAL_RTC_ENABLE_LXT();
+#endif


any clock stuff should be handled by Zephyr clock driver

drivers/bluetooth/hci/hci_sf32lb.c

gmarull · 2025-10-06T08:05:31Z

west.yml

        - hal
    - name: hal_sifli
-      revision: 7be421088b6fa2910917f3f8b656ded01e21b4e8
+      revision: f457f7bea184d5ee4ec4ca45bffe49dd5e72ab1a


for bisectability, pull changes from modules before using them, this also needs to point to open PR (pull/X/head), this SHA does not exist in the repo.

Mbox is hardware interface between Application HCPU and Bluetooth LCPU. Signed-off-by: Gang He <[email protected]>

Add SiFli Bluetooth HCI driver configurations. Signed-off-by: Gang He <[email protected]>

Add configuration support for Bluetooth HCI driver. Signed-off-by: Gang He <[email protected]>

Add mailbox in board devicetree, used in Bluetooth HCI driver. Signed-off-by: Gang He <[email protected]>

Add configuration for SiFli SF32LB chipset Bluetooth HCI driver. Signed-off-by: Gang He <[email protected]>

Add CMakefile script needed for Bluetooth HCI driver. Signed-off-by: Gang He <[email protected]>

SiFli HAL is using HAL_Delay_us to delay for certain microseconds. This is a weak function. I overwrites this function with Zephyr k_sleep. Signed-off-by: Gang He <[email protected]>

Add Bluetooth driver for SF32LB chipsets. Signed-off-by: Gang He <[email protected]>

- Add Bluetooth HCI driver support for SF32LB chipsets Signed-off-by: Gang He <[email protected]>

sonarqubecloud · 2025-10-06T14:41:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
17.3% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added area: Bluetooth area: Boards/SoCs area: Devicetree Bindings platform: SF32LB area: Bluetooth HCI Bluetooth HCI Driver labels Sep 29, 2025

zephyrbot requested review from alwa-nordic, cameled, cvinayak, gmarull, HaavardRei, hermabe, HoZHel, jhedberg, PavelVPV, sjanc and Thalley September 29, 2025 03:14

zephyrbot assigned jhedberg and alwa-nordic Sep 29, 2025

gangheivt force-pushed the main branch from cc9dcd7 to c32e4bf Compare September 29, 2025 06:00

Thalley removed their request for review September 29, 2025 07:34

gmarull reviewed Sep 29, 2025

View reviewed changes

github-actions bot added manifest manifest-mcuboot manifest-hal_nordic manifest-nrf_wifi labels Oct 4, 2025

gangheivt force-pushed the main branch from 0d6f16a to f2edbaa Compare October 4, 2025 03:04

github-actions bot added manifest manifest-hal_sifli DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed manifest manifest-hal_sifli DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 4, 2025

gangheivt force-pushed the main branch from 03bb1ae to 3968320 Compare October 4, 2025 03:29

github-actions bot added manifest manifest-hal_sifli DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed manifest manifest-hal_sifli DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 4, 2025

gangheivt force-pushed the main branch from 8044494 to 19a7102 Compare October 6, 2025 06:40

gmarull requested changes Oct 6, 2025

View reviewed changes

gangheivt force-pushed the main branch from 19a7102 to 3f57e57 Compare October 6, 2025 11:35

zephyrbot requested a review from gmarull October 6, 2025 11:37

gangheivt force-pushed the main branch from 3f57e57 to 6a6e89d Compare October 6, 2025 13:26

Gang He added 9 commits October 6, 2025 21:55

dts: arm: sifli: sf32lb52x： define mailbox

07e0063

Mbox is hardware interface between Application HCPU and Bluetooth LCPU. Signed-off-by: Gang He <[email protected]>

module: sifli: kconfig: Add Bluetooth HCI driver configuration

f29719c

Add SiFli Bluetooth HCI driver configurations. Signed-off-by: Gang He <[email protected]>

soc: sifli: sf32: Add configuration for Bluetooth HCI driver support

44573d1

Add configuration support for Bluetooth HCI driver. Signed-off-by: Gang He <[email protected]>

board: sifli: sf32lb52_devkit_lcd: Add mbox in board device tree

f986411

Add mailbox in board devicetree, used in Bluetooth HCI driver. Signed-off-by: Gang He <[email protected]>

driver: bluetooth: hci: sifli: Add configuration for SF32LB HCI driver.

da560c3

Add configuration for SiFli SF32LB chipset Bluetooth HCI driver. Signed-off-by: Gang He <[email protected]>

module: hal_sifli: Add CMakefile script for bluetooth HCI driver.

1cbab2f

Add CMakefile script needed for Bluetooth HCI driver. Signed-off-by: Gang He <[email protected]>

module: hal_sifli: Overwrite SiFli HAL delay function with k_sleep

a6cf5d9

SiFli HAL is using HAL_Delay_us to delay for certain microseconds. This is a weak function. I overwrites this function with Zephyr k_sleep. Signed-off-by: Gang He <[email protected]>

driver: bluetooth： hci: sifli: Add HCI driver for SF32LB chipsets.

41baab8

Add Bluetooth driver for SF32LB chipsets. Signed-off-by: Gang He <[email protected]>

west.yml: hal_sifli: Update to latest revision

d552bca

- Add Bluetooth HCI driver support for SF32LB chipsets Signed-off-by: Gang He <[email protected]>

gangheivt force-pushed the main branch from 6a6e89d to d552bca Compare October 6, 2025 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Bluetooth HCI driver for SiFli SF32LB chipsets. #96692

Add Bluetooth HCI driver for SiFli SF32LB chipsets. #96692

gangheivt commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

gmarull left a comment

Uh oh!

gangheivt commented Sep 30, 2025

Uh oh!

gmarull commented Sep 30, 2025

Uh oh!

jhedberg commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 4, 2025 •

edited

Loading

Uh oh!

gmarull left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmarull Oct 6, 2025

Uh oh!

Uh oh!

Uh oh!

gmarull Oct 6, 2025

Uh oh!

sonarqubecloud bot commented Oct 6, 2025

Uh oh!

Uh oh!

Add Bluetooth HCI driver for SiFli SF32LB chipsets. #96692

Are you sure you want to change the base?

Add Bluetooth HCI driver for SiFli SF32LB chipsets. #96692

Conversation

gangheivt commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

gangheivt commented Sep 30, 2025

Uh oh!

gmarull commented Sep 30, 2025

Uh oh!

jhedberg commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmarull Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gmarull Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 6, 2025

Quality Gate passed

Uh oh!

Uh oh!

github-actions bot commented Oct 4, 2025 •

edited

Loading