boards native_sim: reboot: Do not close descriptors manually #96812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
zephyrbot
added
area: Boards/SoCs
area: Tests
|
CC @koalatux |
aescolar
requested review from
rugeGerritsen,
henrikbrixandersen,
fabiobaltieri and
jukkar
henrikbrixandersen
approved these changes
Oct 5, 2025
tpambor
reviewed
Oct 5, 2025
jukkar
approved these changes
Oct 6, 2025
Instead rely on them having been opened with O_CLOEXEC, or that whichever component has opened it will close it with a NATIVE/NSI_TASK(ON_EXIT) hook. Signed-off-by: Alberto Escolar Piedras <[email protected]>
This reverts commit 8d7c2e1. The issue should be fixed now. Signed-off-by: Alberto Escolar Piedras <[email protected]>
|
Commit msg fixed. No changes otherwise. |
|
tpambor
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not close descriptors manually on reboot, instead rely on them having been opened with O_CLOEXEC, or that whichever component has opened it will close it with a
NATIVE/NSI_TASK(ON_EXIT)hook.And revert disabling the test
Related to
Fixes #96809
Note: CI failure is unrelated #97046