Skip to content

Conversation

@omkar3141
Copy link
Contributor

@omkar3141 omkar3141 commented Oct 1, 2025

Improve the network message cache to be aware of network keys to prevent false duplicate detection across different subnets. This ensures that messages with the same source address and sequence number but from different network keys are not incorrectly identified as duplicates, as it can happen in certain cases. See ES-26350.

@alxelax
Copy link
Contributor

alxelax commented Oct 2, 2025

LGTM, please convert it to "Ready for review"

@omkar3141 omkar3141 force-pushed the omku/update_net_cache_with_netkeyidx_p2 branch 3 times, most recently from 31a0744 to 2f45249 Compare October 16, 2025 15:27
@omkar3141 omkar3141 force-pushed the omku/update_net_cache_with_netkeyidx_p2 branch 2 times, most recently from ccebbcd to 8a7ed89 Compare October 17, 2025 12:45
@omkar3141 omkar3141 requested review from PavelVPV and alxelax October 22, 2025 15:54
@omkar3141 omkar3141 force-pushed the omku/update_net_cache_with_netkeyidx_p2 branch from 8a7ed89 to 9e2ef24 Compare October 23, 2025 12:16
PavelVPV
PavelVPV previously approved these changes Oct 23, 2025
Improve the network message cache to be aware of network keys to
prevent false duplicate detection across different subnets. This
ensures that messages with the same source address and sequence
number but from different network keys are not incorrectly
identified as duplicates, as it can happen in certain cases.
See ES-26350.

Signed-off-by: Omkar Kulkarni <[email protected]>
@omkar3141 omkar3141 force-pushed the omku/update_net_cache_with_netkeyidx_p2 branch from 9e2ef24 to e8e499c Compare October 23, 2025 12:55
@sonarqubecloud
Copy link

@omkar3141 omkar3141 marked this pull request as ready for review October 24, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants