-
Notifications
You must be signed in to change notification settings - Fork 8k
Forbid usage of NRF_IRONSIDE in mbedtls and secure storage #96915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The NRF_IRONSIDE is a provider of PSA services (including storage) so it cannot be used along with the secure storage subsystem which provides PSA storage APIs. Signed-off-by: Georgios Vasilakis <[email protected]>
The NRF_IRONSIDE provides PSA crypto APIs the same way that the TF-M does. Take that into account in the MBEDTLS configuration configuration. Signed-off-by: Georgios Vasilakis <[email protected]>
6e7d507
to
76cff73
Compare
|
Adding DNM because I see some breakages on the CI that I need to investigate. |
bool | ||
default y | ||
depends on BUILD_WITH_TFM || MBEDTLS_PSA_CRYPTO_C | ||
depends on BUILD_WITH_TFM || MBEDTLS_PSA_CRYPTO_C || NRF_IRONSIDE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valeriosetti with your PR #96415 maybe we could make this Kconfig option just depend on PSA_CRYPTO_PROVIDER
(or PSA_CRYPTO
)?
config MBEDTLS_PSA_CRYPTO_C | ||
bool "Platform Security Architecture cryptography API" | ||
depends on !BUILD_WITH_TFM | ||
depends on !NRF_IRONSIDE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message typos
The NRF_IRONSIDE provides PSA crypto APIs the same way that
theTF-M does. Take that into account in the MBEDTLSconfiguration
configuration.
The NRF_IRONSIDE is a provider of PSA services (including storage and storage) so it cannot be used along with the secure storage subsystem which provides PSA storage APIs or the mbedtls PSA implementation.