tests: Bluetooth: Controller: Fix string formatting #96919
+81
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ll_length_req_send and ll_length_default_set were defined to return a uint32_t, but only returned a uint8_t HCI error code and was the return value was always stored as such. Signed-off-by: Emil Gydesen <[email protected]>
|
An alternative I also considered was to cast |
A handful of Bluetooth controller tests were using %d for non-int values. Some of the values were either uint64_t or long unsigned ints. In most cases, the types could be modified to uint8_t and the formats changed to use %u. In some macros, the types were just cast, as the values would never be larger than uint8_t. The values in this case were defined as e.g. BIT(0), BIT(1) and BIT(2) (which use the UL type in the macro). Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
controller_test_format_fix
branch
from
3f61c7e to
23f94b9
Compare
|
zephyrbot
added
area: Bluetooth
area: Bluetooth Controller
area: Tests
zephyrbot
requested review from
carlescufi,
cvinayak,
erbr-ot,
nashif,
ppryga,
thoh-ot,
Tronil and
wopu-ot
cvinayak
approved these changes
Oct 3, 2025
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a handful of incorrect string formats for some Bluetooth controller tests.