heap_listener: only use designated initializer #96923
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2025 09:50
Run `clang-format` on heap_listener.c and heap_listener.h. Signed-off-by: Jeppe Odgaard <[email protected]>
C++20 require that either all initializer clauses should be designated or none of them should be. Signed-off-by: Jeppe Odgaard <[email protected]>
jeppenodgaard
force-pushed
the
fix/heap_listener_macros
branch
from
3a4b85a to
8824f4a
Compare
jeppenodgaard
changed the title
|
zephyrbot
requested review from
andyross,
dcpleung,
nashif,
npitre and
peter-mitsis
|
Could you skip the formatting patch? It looks worse and more confusing after. |
Can you be more specific about what you dislike? Do you prefer #define HEAP_LISTENER_FREE_DEFINE(name, _heap_id, _free_cb) \
struct heap_listener name = { \
.heap_id = _heap_id, \
.event = HEAP_FREE, \
.cb = { \
.free = _free_cb, \
}, \
}? |
|
Yeah, that's one. Another is the if blocks. Currently it is clear and easier to read that there are 3 conditions AND-ed together. After clang-format, a quick skim through the code may skip the second conditon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++20 require that either all initializer clauses should be designated or
none of them should be.