scripts: west_commands: patch: Fix modules patching mechanism #96929
+70
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script has been using the `zephyr_module.parse_modules` method that is returning only these west project (repositories listed in west manifest) that have module YML/YAML files. Other west project were dropped from the list wast was resulting in patches being skipped for Zephyr and west projects the don't have module file. This patch changes the used method to the one that list all west projects that are specified in the west manifest. Variables and arguments have been changed from `modules` to `projects` to be aligned with West's difinitions. Fixes: zephyrproject-rtos#96927 Signed-off-by: Adam Wojasinski <[email protected]>
awojasinski
force-pushed
the
fix_west_patch
branch
from
7bc8fdd to
0663568
Compare
zephyrbot
requested review from
carlescufi,
kartben,
marc-hb,
mbolivar,
nashif and
swinslow
|
|
@awojasinski - this is definitely more of a feature than a bugfix. I'm not against it being added. The issue that we face currently is that there really are no tests for They could be added, but for the most part, I've had no bandwidth to do it. Can this change be accompanied by tests? That would help us ensure we don't break other downstream users. |
|
Hi @cfriedt thanks for response, sounds like a plan! It will take me some time - I have more important stuff to do - but I agree with you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script has been using the
zephyr_module.parse_modulesmethod that is returning only these west project (repositories listed in west manifest) that have module YML/YAML files. Other west project were dropped from the list wast was resulting in patches being skipped for Zephyr and west projects the don't have module file.This patch changes the used method to the one that list all west projects that are specified in the west manifest. Variables and arguments have been changed from
modulestoprojectsto be aligned with West's difinitions.Fixes: #96927