tests: lib: cpp: cxx: Add test to verify C++ compilation #96944
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using clang to build for RISC-V with these configs:
CONFIG_CPP=y
CONFIG_USERSPACE=n
CONFIG_SMP=n
CONFIG_FPU_SHARING=n
we get the following warnings:
include/zephyr/arch/riscv/structs.h:11:1: error: empty struct has size 0
in C, size 1 in C++ [-Werror,-Wextern-c-compat]
11 | struct _cpu_arch {
| ^
include/zephyr/arch/riscv/thread.h:68:1: error: empty struct has size 0
in C, size 1 in C++ [-Werror,-Wextern-c-compat]
68 | struct _thread_arch {
| ^
This commit adds a test with those configs to verify compilation
succeeds. Although gcc doesn't emit these warnings, we can test with gcc
as well with a BUILD_ASSERT in include/zephyr/arch/riscv/thread.h and
include/zephyr/arch/riscv/structs.h.
Signed-off-by: Tom Hughes <[email protected]>
thughes
force-pushed
the
push-tukkmmylosnk
branch
from
38e5a41 to
dcd2b17
Compare
thughes
changed the title
|
zephyrbot
added
area: Tests
zephyrbot
requested review from
alexanderwachter,
cfriedt,
nashif and
stephanosio
cfriedt
reviewed
Oct 4, 2025
| - CONFIG_STD_CPP23=y | ||
| # Verify struct _cpu_arch struct _thread_arch are compatible with C++ when | ||
| # specific configs are enabled. | ||
| cpp.main.empty_struct_size: |
There was a problem hiding this comment.
It might be good to limit this to run on native_sim and also to elicit coverage with both gcc and llvm.
platform_allow:
- native_sim
integration_platforms:
- native_sim
integration_toolchains:
- host
- llvm
stephanosio
reviewed
Oct 4, 2025
Comment on lines
+81
to
+88
| # Verify struct _cpu_arch struct _thread_arch are compatible with C++ when | ||
| # specific configs are enabled. | ||
| cpp.main.empty_struct_size: | ||
| build_only: true | ||
| extra_configs: | ||
| - CONFIG_USERSPACE=n | ||
| - CONFIG_SMP=n | ||
| - CONFIG_FPU_SHARING=n |
There was a problem hiding this comment.
AFAICS, this is a RISC-V specific issue; so, this should be limited to arch_allow: riscv. Also, a RISC-V integration_platforms should be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using clang to build for RISC-V with these configs:
we get the following warnings:
This commit adds a test with those configs to verify compilation
succeeds. Although gcc doesn't emit these warnings, we can test with gcc
as well with a
BUILD_ASSERTininclude/zephyr/arch/riscv/thread.handinclude/zephyr/arch/riscv/structs.hthat was added in #96943.