drivers: sensor: tdk: icm42x70: update temperature data processing #96971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
MaureenHelm,
afontaine-invn,
asemjonovs,
avisconti,
gjabouley-invn,
jeppenodgaard,
rbuisson-invn,
sriccardi-invn,
teburd,
tristan-google,
ubieda and
yperess
|
@bperseghetti @ubieda please take a look |
afontaine-invn
previously approved these changes
Oct 3, 2025
teburd
requested changes
Oct 3, 2025
ubieda
reviewed
Oct 3, 2025
Shreehari-AlifSemi
force-pushed
the
ZRTSS-619-icm-42670-update-temperature-data-processing
branch
from
e38f335 to
15d889e
Compare
ubieda
previously approved these changes
Oct 8, 2025
ubieda
reviewed
Oct 8, 2025
Update the temperature data processing to handle different data sizes based on FIFO configuration. The temperature sensor data size and conversion formula vary depending on the FIFO mode: 1. FIFO disabled: Uses 20-bit data format 2. FIFO enabled (standard resolution): 16-bit data 3. FIFO enabled (high resolution): 20-bit data The implementation now: - Uses the 'fifo_highres_enabled' flag to determine the correct data size - Applies the appropriate conversion formula based on the resolution mode - Handles all three possible FIFO configurations - Ensures accurate temperature readings in all modes Signed-off-by: Shreehari HK <[email protected]>
Shreehari-AlifSemi
force-pushed
the
ZRTSS-619-icm-42670-update-temperature-data-processing
branch
from
15d889e to
aeae605
Compare
ubieda
approved these changes
Oct 8, 2025
|
Please review this as well: tdk-invn-oss/zephyr.hal_tdk#16 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the temperature data processing to
handle different data sizes based on FIFO configuration. The temperature sensor data size and conversion
formula vary depending on the FIFO mode:
The implementation now: